Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1540535 > unrolled thread

Re: [PATCH] Documentation: ti-syscon-reset: fix header path

Started byRob Herring <robh@kernel.org>
First post2016-12-12 19:50 +0100
Last post2016-12-12 21:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] Documentation: ti-syscon-reset: fix header path Rob Herring <robh@kernel.org> - 2016-12-12 19:50 +0100
    Re: [PATCH] Documentation: ti-syscon-reset: fix header path Yegor Yefremov <yegorslists@googlemail.com> - 2016-12-12 21:00 +0100

#1540535 — Re: [PATCH] Documentation: ti-syscon-reset: fix header path

FromRob Herring <robh@kernel.org>
Date2016-12-12 19:50 +0100
SubjectRe: [PATCH] Documentation: ti-syscon-reset: fix header path
Message-ID<sNDPH-7Pk-7@gated-at.bofh.it>
On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> 'include' was missing from path.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> index 164c7f3..5b20e20 100644
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> @@ -44,7 +44,7 @@ Required properties:
>  			              reset status register
>  			    Cell #7 : Flags used to control reset behavior,
>  			              availible flags defined in the DT include
> -			              file <dt-bindings/reset/ti-syscon.h>
> +			              file <include/dt-bindings/reset/ti-syscon.h>

There's pretty much equal mixture of include or not. Not really much 
point in fixing 1 instance if there's no clear correct way. Given it is 
written with <...>, that matches how you write the include statement.

Rob

[toc] | [next] | [standalone]


#1540580

FromYegor Yefremov <yegorslists@googlemail.com>
Date2016-12-12 21:00 +0100
Message-ID<sNEVw-8r7-15@gated-at.bofh.it>
In reply to#1540535
On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> 'include' was missing from path.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>>  Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> index 164c7f3..5b20e20 100644
>> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> @@ -44,7 +44,7 @@ Required properties:
>>                                     reset status register
>>                           Cell #7 : Flags used to control reset behavior,
>>                                     availible flags defined in the DT include
>> -                                   file <dt-bindings/reset/ti-syscon.h>
>> +                                   file <include/dt-bindings/reset/ti-syscon.h>
>
> There's pretty much equal mixture of include or not. Not really much
> point in fixing 1 instance if there's no clear correct way. Given it is
> written with <...>, that matches how you write the include statement.

OK I see the point of omitting include now. I was looking at this from
VIM point of view. I cannot automatically jump to the file via 'gf'.

Yegor

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web