Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535258 > unrolled thread
| Started by | Brian Norris <briannorris@chromium.org> |
|---|---|
| First post | 2016-12-02 23:40 +0100 |
| Last post | 2016-12-09 15:30 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] devicetree: i2c-hid: Add regulator support Brian Norris <briannorris@chromium.org> - 2016-12-02 23:40 +0100
Re: [PATCH 1/2] devicetree: i2c-hid: Add regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-05 11:10 +0100
Re: [PATCH 1/2] devicetree: i2c-hid: Add regulator support Jiri Kosina <jikos@kernel.org> - 2016-12-09 13:20 +0100
Re: [PATCH 1/2] devicetree: i2c-hid: Add regulator support Rob Herring <robh+dt@kernel.org> - 2016-12-09 15:30 +0100
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Date | 2016-12-02 23:40 +0100 |
| Subject | [PATCH 1/2] devicetree: i2c-hid: Add regulator support |
| Message-ID | <sK4v8-1ix-9@gated-at.bofh.it> |
From: Caesar Wang <wxt@rock-chips.com>
Document a "vdd-supply" and an initialization delay. Can be used for
powering on/off a HID.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
v2:
* add compatible property for wacom, per Rob's request
* name the regulator property specifically (VDD)
v3:
* remove wacom property, per Benjamin's request
* add delay property
v4: no change
---
Documentation/devicetree/bindings/input/hid-over-i2c.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
index 488edcb264c4..1ea290167652 100644
--- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt
+++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
@@ -17,6 +17,11 @@ Required properties:
- interrupt-parent: the phandle for the interrupt controller
- interrupts: interrupt line
+Optional properties:
+- vdd-supply: phandle of the regulator that provides the supply voltage.
+- init-delay-ms: time required by the device after power-on before it is ready
+ for communication.
+
Example:
i2c-hid-dev@2c {
--
2.8.0.rc3.226.g39d4020
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-12-05 11:10 +0100 |
| Message-ID | <sKYnE-3bM-21@gated-at.bofh.it> |
| In reply to | #1535258 |
On Dec 02 2016 or thereabouts, Brian Norris wrote:
> From: Caesar Wang <wxt@rock-chips.com>
>
> Document a "vdd-supply" and an initialization delay. Can be used for
> powering on/off a HID.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> v2:
> * add compatible property for wacom, per Rob's request
> * name the regulator property specifically (VDD)
>
> v3:
> * remove wacom property, per Benjamin's request
> * add delay property
>
> v4: no change
> ---
> Documentation/devicetree/bindings/input/hid-over-i2c.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> index 488edcb264c4..1ea290167652 100644
> --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> @@ -17,6 +17,11 @@ Required properties:
> - interrupt-parent: the phandle for the interrupt controller
> - interrupts: interrupt line
>
> +Optional properties:
> +- vdd-supply: phandle of the regulator that provides the supply voltage.
> +- init-delay-ms: time required by the device after power-on before it is ready
> + for communication.
Nitpick: maybe we should say that the power-on applies to the vdd-supply
parameter, not the SET_POWER HID command. I am just worried people will
misuse this parameter.
Otherwise, Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> +
> Example:
>
> i2c-hid-dev@2c {
> --
> 2.8.0.rc3.226.g39d4020
>
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2016-12-09 13:20 +0100 |
| Message-ID | <sMsjD-38t-9@gated-at.bofh.it> |
| In reply to | #1535258 |
On Fri, 2 Dec 2016, Brian Norris wrote: > From: Caesar Wang <wxt@rock-chips.com> > > Document a "vdd-supply" and an initialization delay. Can be used for > powering on/off a HID. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > v2: > * add compatible property for wacom, per Rob's request > * name the regulator property specifically (VDD) > > v3: > * remove wacom property, per Benjamin's request > * add delay property > > v4: no change Applied both patches to for-4.10/i2c-hid. Thanks, -- Jiri Kosina SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Date | 2016-12-09 15:30 +0100 |
| Message-ID | <sMulr-4n9-33@gated-at.bofh.it> |
| In reply to | #1539310 |
On Fri, Dec 9, 2016 at 6:17 AM, Jiri Kosina <jikos@kernel.org> wrote: > On Fri, 2 Dec 2016, Brian Norris wrote: > >> From: Caesar Wang <wxt@rock-chips.com> >> >> Document a "vdd-supply" and an initialization delay. Can be used for >> powering on/off a HID. >> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Jiri Kosina <jikos@kernel.org> >> Cc: linux-input@vger.kernel.org >> Signed-off-by: Brian Norris <briannorris@chromium.org> >> --- >> v2: >> * add compatible property for wacom, per Rob's request >> * name the regulator property specifically (VDD) >> >> v3: >> * remove wacom property, per Benjamin's request >> * add delay property >> >> v4: no change > > Applied both patches to for-4.10/i2c-hid. In case it wasn't clear: NAK This is still under discussion[1]. Rob [1] https://lkml.org/lkml/2016/12/8/362
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web