Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538867 > unrolled thread
| Started by | Fabian Frederick <fabf@skynet.be> |
|---|---|
| First post | 2016-12-08 21:50 +0100 |
| Last post | 2016-12-08 22:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH V2 2/2] ASoC: samsung: add GPIOLIB dependency Fabian Frederick <fabf@skynet.be> - 2016-12-08 21:50 +0100
Re: [PATCH V2 2/2] ASoC: samsung: add GPIOLIB dependency Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-08 22:00 +0100
| From | Fabian Frederick <fabf@skynet.be> |
|---|---|
| Date | 2016-12-08 21:50 +0100 |
| Subject | [PATCH V2 2/2] ASoC: samsung: add GPIOLIB dependency |
| Message-ID | <sMdND-2nu-13@gated-at.bofh.it> |
Both SND_SOC_SMARTQ and SND_SOC_SAMSUNG_TM2_WM5110
use gpio/consumer.h
This patch adds GPIOLIB || COMPILE_TEST to Kconfig entries
to avoid any build errors.
See commit 638f958baeaf
("extcon: Allow compile test of GPIO consumers if !GPIOLIB")
for similar problem and explanations.
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
sound/soc/samsung/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 7c42315..f1f1d79 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -111,6 +111,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380
config SND_SOC_SMARTQ
tristate "SoC I2S Audio support for SmartQ board"
depends on MACH_SMARTQ || COMPILE_TEST
+ depends on GPIOLIB || COMPILE_TEST
depends on I2C
select SND_SAMSUNG_I2S
select SND_SOC_WM8750
@@ -193,6 +194,7 @@ config SND_SOC_ARNDALE_RT5631_ALC5631
config SND_SOC_SAMSUNG_TM2_WM5110
tristate "SoC I2S Audio support for WM5110 on TM2 board"
depends on SND_SOC_SAMSUNG && MFD_ARIZONA && I2C && SPI_MASTER
+ depends on GPIOLIB || COMPILE_TEST
select SND_SOC_MAX98504
select SND_SOC_WM5110
select SND_SAMSUNG_I2S
--
2.7.4
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-12-08 22:00 +0100 |
| Message-ID | <sMdXk-2rQ-21@gated-at.bofh.it> |
| In reply to | #1538867 |
On Thu, Dec 08, 2016 at 09:43:19PM +0100, Fabian Frederick wrote:
> Both SND_SOC_SMARTQ and SND_SOC_SAMSUNG_TM2_WM5110
> use gpio/consumer.h
> This patch adds GPIOLIB || COMPILE_TEST to Kconfig entries
> to avoid any build errors.
I think that is not entirely correct. There won't be build errors here
because build dependency is satisfied by header (for both cases: GPIOLIB
and !GPIOLIB). However this fixes runtime dependency - the driver
requires GPIOLIB to work.
Beside the commit msg, it is okay:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> See commit 638f958baeaf
> ("extcon: Allow compile test of GPIO consumers if !GPIOLIB")
>
> for similar problem and explanations.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> sound/soc/samsung/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index 7c42315..f1f1d79 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -111,6 +111,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380
> config SND_SOC_SMARTQ
> tristate "SoC I2S Audio support for SmartQ board"
> depends on MACH_SMARTQ || COMPILE_TEST
> + depends on GPIOLIB || COMPILE_TEST
> depends on I2C
> select SND_SAMSUNG_I2S
> select SND_SOC_WM8750
> @@ -193,6 +194,7 @@ config SND_SOC_ARNDALE_RT5631_ALC5631
> config SND_SOC_SAMSUNG_TM2_WM5110
> tristate "SoC I2S Audio support for WM5110 on TM2 board"
> depends on SND_SOC_SAMSUNG && MFD_ARIZONA && I2C && SPI_MASTER
> + depends on GPIOLIB || COMPILE_TEST
> select SND_SOC_MAX98504
> select SND_SOC_WM5110
> select SND_SAMSUNG_I2S
> --
> 2.7.4
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web