Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538672 > unrolled thread
| Started by | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| First post | 2016-12-08 17:20 +0100 |
| Last post | 2016-12-08 21:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-08 17:20 +0100
Re: [PATCH] staging: lustre: Fix variable type declaration after refactoring Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-08 20:40 +0100
[PATCH v2] staging: lustre: Fix variable type declaration after refactoring Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-08 21:50 +0100
| From | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| Date | 2016-12-08 17:20 +0100 |
| Subject | [PATCH] staging: lustre: Fix variable type declaration after refactoring |
| Message-ID | <sM9Al-8ha-21@gated-at.bofh.it> |
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-12-08 20:40 +0100 |
| Subject | Re: [PATCH] staging: lustre: Fix variable type declaration after refactoring |
| Message-ID | <sMcHT-1En-7@gated-at.bofh.it> |
| In reply to | #1538672 |
On Thu, Dec 08, 2016 at 05:07:59PM +0100, Quentin Lambert wrote:
> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.
>
> Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
0a1200991234f7
Fixes hash is wrong. It should start with "0a".
regards,
dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| Date | 2016-12-08 21:50 +0100 |
| Subject | [PATCH v2] staging: lustre: Fix variable type declaration after refactoring |
| Message-ID | <sMdNE-2nu-15@gated-at.bofh.it> |
| In reply to | #1538672 |
A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:
drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer
This patch fixes this issue.
Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
v2: fixes the referenced sha
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};
#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web