Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1539742 > unrolled thread
| Started by | Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
|---|---|
| First post | 2016-12-10 01:00 +0100 |
| Last post | 2016-12-10 03:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-12-10 01:00 +0100
Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-10 03:10 +0100
| From | Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
|---|---|
| Date | 2016-12-10 01:00 +0100 |
| Subject | [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP |
| Message-ID | <sMDf3-1aX-9@gated-at.bofh.it> |
As this define check if huge, this makes easier to read the code.
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
While reviewing patches from Dmitry about presence of 8042, it makes it
much easier to understand the ifdefs...
drivers/input/serio/i8042-x86ia64io.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 073246c..ddd3132 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
return 0;
}
-#else
+#else /* !CONFIG_PNP */
static inline int i8042_pnp_init(void) { return 0; }
static inline void i8042_pnp_exit(void) { }
-#endif
+#endif /* CONFIG_PNP */
static int __init i8042_platform_init(void)
{
--
2.9.3
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-12-10 03:10 +0100 |
| Subject | Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP |
| Message-ID | <sMFgR-2zG-5@gated-at.bofh.it> |
| In reply to | #1539742 |
On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote:
> As this define check if huge, this makes easier to read the code.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Applied, thank you.
> ---
> While reviewing patches from Dmitry about presence of 8042, it makes it
> much easier to understand the ifdefs...
>
> drivers/input/serio/i8042-x86ia64io.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 073246c..ddd3132 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
> return 0;
> }
>
> -#else
> +#else /* !CONFIG_PNP */
> static inline int i8042_pnp_init(void) { return 0; }
> static inline void i8042_pnp_exit(void) { }
> -#endif
> +#endif /* CONFIG_PNP */
>
> static int __init i8042_platform_init(void)
> {
> --
> 2.9.3
>
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web