Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535750 > unrolled thread

[PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

Started byMilo Kim <woogyom.kim@gmail.com>
First post2016-12-05 03:10 +0100
Last post2016-12-06 15:30 +0100
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim <woogyom.kim@gmail.com> - 2016-12-05 03:10 +0100
    [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo Milo Kim <woogyom.kim@gmail.com> - 2016-12-05 03:10 +0100
    Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-05 09:10 +0100
      Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim <woogyom.kim@gmail.com> - 2016-12-06 08:40 +0100
        Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-06 15:10 +0100
          Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim <woogyom.kim@gmail.com> - 2016-12-06 15:30 +0100

#1535750 — [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

FromMilo Kim <woogyom.kim@gmail.com>
Date2016-12-05 03:10 +0100
Subject[PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
Message-ID<sKQT7-6HH-3@gated-at.bofh.it>
The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
 	model = "FriendlyArm NanoPi M1";
 	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x20000000>;
+	};
 };
 
 &ehci1 {
-- 
2.9.3

[toc] | [next] | [standalone]

#1535751 — [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo

FromMilo Kim <woogyom.kim@gmail.com>
Date2016-12-05 03:10 +0100
Subject[PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo
Message-ID<sKQT7-6HH-9@gated-at.bofh.it>
In reply to#1535750
The board has DDR3 256MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
index 8d2cc6e..433f55d 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
@@ -45,4 +45,9 @@
 / {
 	model = "FriendlyARM NanoPi NEO";
 	compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x10000000>;
+	};
 };
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1535877

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-12-05 09:10 +0100
Message-ID<sKWvv-1WP-3@gated-at.bofh.it>
In reply to#1535750

[Multipart message — attachments visible in raw view] — view raw

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> The board has DDR3 512MB. This patch helps scanning the memory and
> adding memblock through the DT.
> 
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> index ec63d10..be3668f 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> @@ -45,6 +45,11 @@
>  / {
>  	model = "FriendlyArm NanoPi M1";
>  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> +
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0x40000000 0x20000000>;
> +	};

U-boot will fill that up, so there's no need to put it there.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1536724

FromMilo Kim <woogyom.kim@gmail.com>
Date2016-12-06 08:40 +0100
Message-ID<sLiw1-7v1-9@gated-at.bofh.it>
In reply to#1535877
On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
>> The board has DDR3 512MB. This patch helps scanning the memory and
>> adding memblock through the DT.
>>
>> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
>> ---
>>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> index ec63d10..be3668f 100644
>> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> @@ -45,6 +45,11 @@
>>  / {
>>  	model = "FriendlyArm NanoPi M1";
>>  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
>> +
>> +	memory@40000000 {
>> +		device_type = "memory";
>> +		reg = <0x40000000 0x20000000>;
>> +	};
>
> U-boot will fill that up, so there's no need to put it there.

Right, my intention was adding memblock through the DT whether the 
bootload does or not. However I'm not sure the situation (missing 
memblock in u-boot) could really happen.

Best regards,
Milo

[toc] | [prev] | [next] | [standalone]

#1536991

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-12-06 15:10 +0100
Message-ID<sLoBr-335-1@gated-at.bofh.it>
In reply to#1536724

[Multipart message — attachments visible in raw view] — view raw

On Tue, Dec 06, 2016 at 04:23:57PM +0900, Milo Kim wrote:
> On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> > On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> > > The board has DDR3 512MB. This patch helps scanning the memory and
> > > adding memblock through the DT.
> > > 
> > > Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > index ec63d10..be3668f 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > @@ -45,6 +45,11 @@
> > >  / {
> > >  	model = "FriendlyArm NanoPi M1";
> > >  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> > > +
> > > +	memory@40000000 {
> > > +		device_type = "memory";
> > > +		reg = <0x40000000 0x20000000>;
> > > +	};
> > 
> > U-boot will fill that up, so there's no need to put it there.
> 
> Right, my intention was adding memblock through the DT whether the bootload
> does or not. However I'm not sure the situation (missing memblock in u-boot)
> could really happen.

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1537005

FromMilo Kim <woogyom.kim@gmail.com>
Date2016-12-06 15:30 +0100
Message-ID<sLoUO-3cX-25@gated-at.bofh.it>
In reply to#1536991
On 12/06/2016 11:00 PM, Maxime Ripard wrote:
> No, we need a recent U-Boot in order to boot, and such a uboot will
> setup the memory node anyway.

Got it. Thanks! Please just ignore my patches.

Best regards,
Milo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web