Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530762 > unrolled thread

[PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Borislav Petkov <bp@alien8.de> - 2016-11-26 19:40 +0100
    Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Keith Busch <keith.busch@intel.com> - 2016-11-28 17:30 +0100
    Re: [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning Bjorn Helgaas <helgaas@kernel.org> - 2016-12-07 19:20 +0100

#1530762 — [PATCH] drivers/pci/host/vmd: Fix suspend handlers unused warning

From: Borislav Petkov <bp@suse.de>

Fix:

  drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
   static int vmd_suspend(struct device *dev)
              ^
  drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
   static int vmd_resume(struct device *dev)
              ^

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/host/vmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
index 37e29b580be3..0e7f8f319fe3 100644
--- a/drivers/pci/host/vmd.c
+++ b/drivers/pci/host/vmd.c
@@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
 	irq_domain_remove(vmd->irq_domain);
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int vmd_suspend(struct device *dev)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
-- 
2.10.0

[toc] | [next] | [standalone]

#1531425

On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> Fix:
> 
>   drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
>    static int vmd_suspend(struct device *dev)
>               ^
>   drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
>    static int vmd_resume(struct device *dev)
>               ^
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>

Thanks for the fix.

Reviewed-by: Keith Busch <keith.busch@intel.com>

[toc] | [prev] | [next] | [standalone]

#1537970

On Sat, Nov 26, 2016 at 07:29:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> Fix:
> 
>   drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
>    static int vmd_suspend(struct device *dev)
>               ^
>   drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
>    static int vmd_resume(struct device *dev)
>               ^
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org

Applied with Keith's reviewed-by to pci/host-vmd for v4.10, thanks!

> ---
>  drivers/pci/host/vmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index 37e29b580be3..0e7f8f319fe3 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
>  	irq_domain_remove(vmd->irq_domain);
>  }
>  
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>  static int vmd_suspend(struct device *dev)
>  {
>  	struct pci_dev *pdev = to_pci_dev(dev);
> -- 
> 2.10.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web