Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535321 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2016-12-03 03:10 +0100 |
| Last post | 2016-12-05 20:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-12-03 03:10 +0100
Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read Grygorii Strashko <grygorii.strashko@ti.com> - 2016-12-05 19:50 +0100
Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read David Miller <davem@davemloft.net> - 2016-12-05 20:50 +0100
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2016-12-03 03:10 +0100 |
| Subject | [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read |
| Message-ID | <sK7W1-3u6-5@gated-at.bofh.it> |
There is desc_read() macros to read desc fields, so no need to
use __raw_readl();
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master
drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index c776e45..d96dca5 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
}
desc_dma = desc_phys(pool, desc);
- status = __raw_readl(&desc->hw_mode);
+ status = desc_read(desc, hw_mode);
outlen = status & 0x7ff;
if (status & CPDMA_DESC_OWNER) {
chan->stats.busy_dequeue++;
--
2.7.4
[toc] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-12-05 19:50 +0100 |
| Subject | Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read |
| Message-ID | <sL6uR-8aT-11@gated-at.bofh.it> |
| In reply to | #1535321 |
On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
> There is desc_read() macros to read desc fields, so no need to
> use __raw_readl();
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
I'm going to update it all at once as part of [1].
[1] https://lkml.org/lkml/2016/12/1/781
> ---
> Based on net-next/master
>
> drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index c776e45..d96dca5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
> }
> desc_dma = desc_phys(pool, desc);
>
> - status = __raw_readl(&desc->hw_mode);
> + status = desc_read(desc, hw_mode);
> outlen = status & 0x7ff;
> if (status & CPDMA_DESC_OWNER) {
> chan->stats.busy_dequeue++;
>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-12-05 20:50 +0100 |
| Subject | Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read |
| Message-ID | <sL7qV-hs-7@gated-at.bofh.it> |
| In reply to | #1536336 |
From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Mon, 5 Dec 2016 12:47:16 -0600 > > > On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: >> There is desc_read() macros to read desc fields, so no need to >> use __raw_readl(); >> >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > > > I'm going to update it all at once as part of [1]. > > [1] https://lkml.org/lkml/2016/12/1/781 Ok.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web