Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535595 > unrolled thread

[PATCH 1/1] atm: fix improper return value

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] atm: fix improper return value Pan Bian <bianpan201603@163.com> - 2016-12-04 06:50 +0100
    Re: [PATCH 1/1] atm: fix improper return value David Miller <davem@davemloft.net> - 2016-12-05 21:00 +0100

#1535595 — [PATCH 1/1] atm: fix improper return value

From: Pan Bian <bianpan2016@163.com>

It returns variable "error" when ioremap_nocache() returns a NULL
pointer. The value of "error" is 0 then, which will mislead the callers
to believe that there is no error. This patch fixes the bug, returning
"-ENOMEM".

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/atm/eni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index f2aaf9e..40c2d56 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1727,7 +1727,7 @@ static int eni_do_init(struct atm_dev *dev)
 		printk("\n");
 		printk(KERN_ERR DEV_LABEL "(itf %d): can't set up page "
 		    "mapping\n",dev->number);
-		return error;
+		return -ENOMEM;
 	}
 	eni_dev->ioaddr = base;
 	eni_dev->base_diff = real_base - (unsigned long) base;
-- 
1.9.1

[toc] | [next] | [standalone]

#1536369

From: Pan Bian <bianpan201603@163.com>
Date: Sun,  4 Dec 2016 13:45:15 +0800

> From: Pan Bian <bianpan2016@163.com>
> 
> It returns variable "error" when ioremap_nocache() returns a NULL
> pointer. The value of "error" is 0 then, which will mislead the callers
> to believe that there is no error. This patch fixes the bug, returning
> "-ENOMEM".
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web