Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535138 > unrolled thread

[PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning

Back to article view | Back to linux.kernel

Contents

  [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning Fabian Frederick <fabf@skynet.be> - 2016-12-02 20:30 +0100
    Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to  persistence warning Dan Williams <dan.j.williams@intel.com> - 2016-12-02 22:00 +0100

#1535138 — [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/nvdimm/pmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 2461843..822a712 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
 	pmem->phys_addr = res->start;
 	pmem->size = resource_size(res);
 	if (nvdimm_has_flush(nd_region) < 0)
-		dev_warn(dev, "unable to guarantee persistence of writes\n");
+		dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
 
 	if (!devm_request_mem_region(dev, res->start, resource_size(res),
 				dev_name(dev))) {
-- 
2.7.4

[toc] | [next] | [standalone]

#1535212 — Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning

On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@skynet.be> wrote:
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/nvdimm/pmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 2461843..822a712 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
>         pmem->phys_addr = res->start;
>         pmem->size = resource_size(res);
>         if (nvdimm_has_flush(nd_region) < 0)
> -               dev_warn(dev, "unable to guarantee persistence of writes\n");
> +               dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");

I'll pass on this one. Another reason could be that the flushing
capability is present but disabled.  Just seeing it's not guaranteed
is sufficient.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web