Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533802 > unrolled thread
| Started by | Shailendra Verma <shailendra.v@samsung.com> |
|---|---|
| First post | 2016-12-01 06:00 +0100 |
| Last post | 2016-12-01 11:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Platform: vsp1: Clean up file handle in open() error path. Shailendra Verma <shailendra.v@samsung.com> - 2016-12-01 06:00 +0100
Re: [PATCH] Platform: vsp1: Clean up file handle in open() error path. Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-01 11:40 +0100
| From | Shailendra Verma <shailendra.v@samsung.com> |
|---|---|
| Date | 2016-12-01 06:00 +0100 |
| Subject | [PATCH] Platform: vsp1: Clean up file handle in open() error path. |
| Message-ID | <sJrDr-7sX-1@gated-at.bofh.it> |
v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
before returing from the function.
Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
drivers/media/platform/vsp1/vsp1_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index d351b9c..cc58163 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file)
ret = vsp1_device_get(video->vsp1);
if (ret < 0) {
v4l2_fh_del(vfh);
+ v4l2_fh_exit(vfh);
kfree(vfh);
}
--
1.7.9.5
[toc] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2016-12-01 11:40 +0100 |
| Message-ID | <sJwWt-2GE-5@gated-at.bofh.it> |
| In reply to | #1533802 |
Hi Shailendra,
Thank you for the patch.
On Thursday 01 Dec 2016 10:20:18 Shailendra Verma wrote:
> v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
> before returing from the function.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree for v4.11.
> ---
> drivers/media/platform/vsp1/vsp1_video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index d351b9c..cc58163 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file)
> ret = vsp1_device_get(video->vsp1);
> if (ret < 0) {
> v4l2_fh_del(vfh);
> + v4l2_fh_exit(vfh);
> kfree(vfh);
> }
--
Regards,
Laurent Pinchart
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web