Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533818 > unrolled thread
| Started by | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| First post | 2016-12-01 06:40 +0100 |
| Last post | 2016-12-01 06:40 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC][PATCHv4 3/6] printk: introduce per-cpu safe_print seq buffer Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-01 06:40 +0100
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2016-12-01 06:40 +0100 |
| Subject | Re: [RFC][PATCHv4 3/6] printk: introduce per-cpu safe_print seq buffer |
| Message-ID | <sJsg9-7Ys-5@gated-at.bofh.it> |
On (11/24/16 17:58), Petr Mladek wrote:
[..]
> > +/*
> > + * Lockless printk(), to avoid deadlocks should the printk() recurse
> > + * into itself. It uses a per-CPU buffer to store the message, just like
> > + * NMI.
> > + */
> > +static int vprintk_safe(const char *fmt, va_list args)
> > +{
> > + struct printk_safe_seq_buf *s = this_cpu_ptr(&safe_print_seq);
> > +
> > + return printk_safe_log_store(s, fmt, args);
>
> We should return zero if printk_safe_log_store() returns an error.
> I know that it will get fixed in the next patch. But we should do
> some minimum sanity check here because of bisection.
by the way. vprintk_safe() and the entire printk_safe mechanism are
not yet used in this patch. the patch that enables it comes in later.
-ss
Back to top | Article view | linux.kernel
csiph-web