Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533563 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2016-11-30 22:00 +0100 |
| Last post | 2016-12-01 10:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 4/9] clk: stm32f4: Add lcd-tft clock Rob Herring <robh@kernel.org> - 2016-11-30 22:00 +0100
Re: [PATCH v2 4/9] clk: stm32f4: Add lcd-tft clock Gabriel Fernandez <gabriel.fernandez@st.com> - 2016-12-01 10:10 +0100
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-11-30 22:00 +0100 |
| Subject | Re: [PATCH v2 4/9] clk: stm32f4: Add lcd-tft clock |
| Message-ID | <sJk8V-2ve-1@gated-at.bofh.it> |
On Thu, Nov 24, 2016 at 03:45:44PM +0100, gabriel.fernandez@st.com wrote: > From: Gabriel Fernandez <gabriel.fernandez@st.com> > > This patch introduces lcd-tft clock for stm32f4 soc. > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com> > --- > .../devicetree/bindings/clock/st,stm32-rcc.txt | 1 + > drivers/clk/clk-stm32f4.c | 118 +++++++++++++++++++++ > include/dt-bindings/clock/stm32f4-clock.h | 3 +- > 3 files changed, 121 insertions(+), 1 deletion(-) > diff --git a/include/dt-bindings/clock/stm32f4-clock.h b/include/dt-bindings/clock/stm32f4-clock.h > index 56b8e10..1be4a3a 100644 > --- a/include/dt-bindings/clock/stm32f4-clock.h > +++ b/include/dt-bindings/clock/stm32f4-clock.h > @@ -27,7 +27,8 @@ > #define CLK_RTC 5 > #define PLL_VCO_I2S 6 > #define PLL_VCO_SAI 7 > +#define CLK_LCD 8 > > -#define END_PRIMARY_CLK 8 > +#define END_PRIMARY_CLK 9 Do you really need this? Having this change could cause compatibility problems between dtb and kernel versions. Please restructure the patch series and put all of the binding changes including this header into a single patch. Incrementally add s/w features, not h/w. Rob
[toc] | [next] | [standalone]
| From | Gabriel Fernandez <gabriel.fernandez@st.com> |
|---|---|
| Date | 2016-12-01 10:10 +0100 |
| Message-ID | <sJvxo-1QI-47@gated-at.bofh.it> |
| In reply to | #1533563 |
Hi Rob, Thanks for reviewing On 11/30/2016 09:53 PM, Rob Herring wrote: > On Thu, Nov 24, 2016 at 03:45:44PM +0100, gabriel.fernandez@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernandez@st.com> >> >> This patch introduces lcd-tft clock for stm32f4 soc. >> >> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com> >> --- >> .../devicetree/bindings/clock/st,stm32-rcc.txt | 1 + >> drivers/clk/clk-stm32f4.c | 118 +++++++++++++++++++++ >> include/dt-bindings/clock/stm32f4-clock.h | 3 +- >> 3 files changed, 121 insertions(+), 1 deletion(-) > >> diff --git a/include/dt-bindings/clock/stm32f4-clock.h b/include/dt-bindings/clock/stm32f4-clock.h >> index 56b8e10..1be4a3a 100644 >> --- a/include/dt-bindings/clock/stm32f4-clock.h >> +++ b/include/dt-bindings/clock/stm32f4-clock.h >> @@ -27,7 +27,8 @@ >> #define CLK_RTC 5 >> #define PLL_VCO_I2S 6 >> #define PLL_VCO_SAI 7 >> +#define CLK_LCD 8 >> >> -#define END_PRIMARY_CLK 8 >> +#define END_PRIMARY_CLK 9 > Do you really need this? Having this change could cause compatibility > problems between dtb and kernel versions. > > Please restructure the patch series and put all of the binding changes > including this header into a single patch. Incrementally add s/w > features, not h/w. > > Rob Okay Best Regards Gabriel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web