Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532434 > unrolled thread
| Started by | Richard Fitzgerald <rf@opensource.wolfsonmicro.com> |
|---|---|
| First post | 2016-11-29 16:50 +0100 |
| Last post | 2016-12-01 03:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-11-29 16:50 +0100
Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions Chanwoo Choi <cw00.choi@samsung.com> - 2016-11-30 01:20 +0100
Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions Mark Brown <broonie@kernel.org> - 2016-11-30 18:30 +0100
Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-01 03:00 +0100
| From | Richard Fitzgerald <rf@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2016-11-29 16:50 +0100 |
| Subject | [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions |
| Message-ID | <sISPn-1Rc-1@gated-at.bofh.it> |
The name of a codec pin can have an optional prefix string, which is
defined by the SoC machine driver. The snd_soc_dapm_x_pin functions
take the fully-specified name including the prefix and so the existing
code would fail to find the pin if the audio machine driver had added
a prefix.
Switch to using the snd_soc_component_x_pin equivalent functions that
take a specified SoC component and automatically add the name prefix to
the provided pin name.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
drivers/extcon/extcon-arizona.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index aeab47d..ed78b7c 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -270,9 +270,10 @@ static void arizona_extcon_pulse_micbias(struct arizona_extcon_info *info)
struct arizona *arizona = info->arizona;
const char *widget = arizona_extcon_get_micbias(info);
struct snd_soc_dapm_context *dapm = arizona->dapm;
+ struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
int ret;
- ret = snd_soc_dapm_force_enable_pin(dapm, widget);
+ ret = snd_soc_component_force_enable_pin(component, widget);
if (ret != 0)
dev_warn(arizona->dev, "Failed to enable %s: %d\n",
widget, ret);
@@ -280,7 +281,7 @@ static void arizona_extcon_pulse_micbias(struct arizona_extcon_info *info)
snd_soc_dapm_sync(dapm);
if (!arizona->pdata.micd_force_micbias) {
- ret = snd_soc_dapm_disable_pin(arizona->dapm, widget);
+ ret = snd_soc_component_disable_pin(component, widget);
if (ret != 0)
dev_warn(arizona->dev, "Failed to disable %s: %d\n",
widget, ret);
@@ -345,6 +346,7 @@ static void arizona_stop_mic(struct arizona_extcon_info *info)
struct arizona *arizona = info->arizona;
const char *widget = arizona_extcon_get_micbias(info);
struct snd_soc_dapm_context *dapm = arizona->dapm;
+ struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
bool change;
int ret;
@@ -352,7 +354,7 @@ static void arizona_stop_mic(struct arizona_extcon_info *info)
ARIZONA_MICD_ENA, 0,
&change);
- ret = snd_soc_dapm_disable_pin(dapm, widget);
+ ret = snd_soc_component_disable_pin(component, widget);
if (ret != 0)
dev_warn(arizona->dev,
"Failed to disable %s: %d\n",
--
1.9.1
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-11-30 01:20 +0100 |
| Subject | Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions |
| Message-ID | <sJ0MW-79y-15@gated-at.bofh.it> |
| In reply to | #1532434 |
Hi Richard,
I have no any objection for this patch.
But, the patch4 is dependent on patch1.
After finished the review of patch1,
I'll add acekd-by tag.
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 00:44, Richard Fitzgerald wrote:
> The name of a codec pin can have an optional prefix string, which is
> defined by the SoC machine driver. The snd_soc_dapm_x_pin functions
> take the fully-specified name including the prefix and so the existing
> code would fail to find the pin if the audio machine driver had added
> a prefix.
>
> Switch to using the snd_soc_component_x_pin equivalent functions that
> take a specified SoC component and automatically add the name prefix to
> the provided pin name.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index aeab47d..ed78b7c 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -270,9 +270,10 @@ static void arizona_extcon_pulse_micbias(struct arizona_extcon_info *info)
> struct arizona *arizona = info->arizona;
> const char *widget = arizona_extcon_get_micbias(info);
> struct snd_soc_dapm_context *dapm = arizona->dapm;
> + struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
> int ret;
>
> - ret = snd_soc_dapm_force_enable_pin(dapm, widget);
> + ret = snd_soc_component_force_enable_pin(component, widget);
> if (ret != 0)
> dev_warn(arizona->dev, "Failed to enable %s: %d\n",
> widget, ret);
> @@ -280,7 +281,7 @@ static void arizona_extcon_pulse_micbias(struct arizona_extcon_info *info)
> snd_soc_dapm_sync(dapm);
>
> if (!arizona->pdata.micd_force_micbias) {
> - ret = snd_soc_dapm_disable_pin(arizona->dapm, widget);
> + ret = snd_soc_component_disable_pin(component, widget);
> if (ret != 0)
> dev_warn(arizona->dev, "Failed to disable %s: %d\n",
> widget, ret);
> @@ -345,6 +346,7 @@ static void arizona_stop_mic(struct arizona_extcon_info *info)
> struct arizona *arizona = info->arizona;
> const char *widget = arizona_extcon_get_micbias(info);
> struct snd_soc_dapm_context *dapm = arizona->dapm;
> + struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
> bool change;
> int ret;
>
> @@ -352,7 +354,7 @@ static void arizona_stop_mic(struct arizona_extcon_info *info)
> ARIZONA_MICD_ENA, 0,
> &change);
>
> - ret = snd_soc_dapm_disable_pin(dapm, widget);
> + ret = snd_soc_component_disable_pin(component, widget);
> if (ret != 0)
> dev_warn(arizona->dev,
> "Failed to disable %s: %d\n",
>
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-11-30 18:30 +0100 |
| Subject | Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions |
| Message-ID | <sJgRI-yy-3@gated-at.bofh.it> |
| In reply to | #1532861 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Nov 30, 2016 at 09:19:14AM +0900, Chanwoo Choi wrote:
> But, the patch4 is dependent on patch1.
> After finished the review of patch1,
> I'll add acekd-by tag.
Or you can just pull in that patch, whichever is easiest - I've created
a tag:
The following changes since commit 1001354ca34179f3db924eb66672442a173147dc:
Linux 4.9-rc1 (2016-10-15 12:17:50 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-dapm-pin-component
for you to fetch changes up to 1b4d9c22191583ef1fb7433417b2ceb2a608d887:
ASoC: core: Add component pin control functions (2016-11-30 17:16:09 +0000)
----------------------------------------------------------------
ASoC: Pin enable controls for components
Provide an interface for devices to manipulate their own pins in DAPM
without being affected by the renaming facilities provided by ASoC for
machine drivers.
----------------------------------------------------------------
Richard Fitzgerald (1):
ASoC: core: Add component pin control functions
include/sound/soc.h | 20 +++++
sound/soc/soc-utils.c | 199 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 219 insertions(+)
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-12-01 03:00 +0100 |
| Subject | Re: [PATCH V2 4/5] extcon: arizona: Use SoC component pin control functions |
| Message-ID | <sJoPg-5Bo-15@gated-at.bofh.it> |
| In reply to | #1533459 |
Dear Mark, On 2016년 12월 01일 02:27, Mark Brown wrote: > On Wed, Nov 30, 2016 at 09:19:14AM +0900, Chanwoo Choi wrote: > >> But, the patch4 is dependent on patch1. >> After finished the review of patch1, >> I'll add acekd-by tag. > > Or you can just pull in that patch, whichever is easiest - I've created > a tag: I hope that you apply this patch on your tree with my Acked tag. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> [snip] -- Best Regards, Chanwoo Choi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web