Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533386 > unrolled thread
| Started by | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| First post | 2016-11-30 16:30 +0100 |
| Last post | 2016-12-02 11:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse() Kim Phillips <kim.phillips@arm.com> - 2016-11-30 16:30 +0100
Re: [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-11-30 16:50 +0100
[tip:perf/core] perf annotate: Use arch->objdump.comment_char in dec__parse() tip-bot for Kim Phillips <tipbot@zytor.com> - 2016-12-02 11:50 +0100
| From | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| Date | 2016-11-30 16:30 +0100 |
| Subject | [PATCH 1/2] perf annotate: use arch->objdump.comment_char in dec__parse() |
| Message-ID | <sJeZA-7OM-23@gated-at.bofh.it> |
Presume neglected in commit 786c1b5 "perf annotate: Start supporting cross arch annotation". This doesn't fix a bug since none of the affected arches support parsing dec/inc instructions yet. Signed-off-by: Kim Phillips <kim.phillips@arm.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 3e34ee0..191599e 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops if (ops->target.raw == NULL) return -1; - comment = strchr(s, '#'); + comment = strchr(s, arch->objdump.comment_char); if (comment == NULL) return 0; -- 2.10.2
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2016-11-30 16:50 +0100 |
| Message-ID | <sJfiV-7Va-3@gated-at.bofh.it> |
| In reply to | #1533386 |
Em Wed, Nov 30, 2016 at 09:23:33AM -0600, Kim Phillips escreveu: > Presume neglected in commit 786c1b5 "perf annotate: Start supporting > cross arch annotation". This doesn't fix a bug since none of the > affected arches support parsing dec/inc instructions yet. Applied, good catch, one tiny nit tho: [PATCH 1/2] perf annotate: use arch->objdump.comment_char in Please start the summary with a capital letter, i.e. make the above be: [PATCH 1/2] perf annotate: Use arch->objdump.comment_char in That is how I've worked pushing stuff to Ingo for years, so for consistency, please stick to that in your next patches, Thanks a lot! - Arnaldo > Signed-off-by: Kim Phillips <kim.phillips@arm.com> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > --- > tools/perf/util/annotate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 3e34ee0..191599e 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops > if (ops->target.raw == NULL) > return -1; > > - comment = strchr(s, '#'); > + comment = strchr(s, arch->objdump.comment_char); > if (comment == NULL) > return 0; > > -- > 2.10.2
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Kim Phillips <tipbot@zytor.com> |
|---|---|
| Date | 2016-12-02 11:50 +0100 |
| Subject | [tip:perf/core] perf annotate: Use arch->objdump.comment_char in dec__parse() |
| Message-ID | <sJTzH-2Il-23@gated-at.bofh.it> |
| In reply to | #1533386 |
Commit-ID: 859afa6ca9321346800bac0ee478c9a99c4babaf Gitweb: http://git.kernel.org/tip/859afa6ca9321346800bac0ee478c9a99c4babaf Author: Kim Phillips <kim.phillips@arm.com> AuthorDate: Wed, 30 Nov 2016 09:23:33 -0600 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 1 Dec 2016 13:03:18 -0300 perf annotate: Use arch->objdump.comment_char in dec__parse() Presume neglected in commit 786c1b5 "perf annotate: Start supporting cross arch annotation". This doesn't fix a bug since none of the affected arches support parsing dec/inc instructions yet. Signed-off-by: Kim Phillips <kim.phillips@arm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Chris Ryder <chris.ryder@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Will Deacon <will.deacon@arm.com> Link: http://lkml.kernel.org/r/20161130092333.1cca5dd2c77e1790d61c1e9c@arm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 3e34ee0..191599e 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops if (ops->target.raw == NULL) return -1; - comment = strchr(s, '#'); + comment = strchr(s, arch->objdump.comment_char); if (comment == NULL) return 0;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web