Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1532369 > unrolled thread

Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-11-29 16:00 +0100
Last post2016-11-30 13:50 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-29 16:00 +0100
    Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Guenter Roeck <linux@roeck-us.net> - 2016-11-30 12:00 +0100
      Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-30 13:50 +0100

#1532369 — Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-11-29 16:00 +0100
SubjectRe: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS
Message-ID<sIS30-1lb-25@gated-at.bofh.it>
Hello Wim,

On 10/20/2016 07:28 PM, Guenter Roeck wrote:
> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>> The Amlogic Meson is a DT-only platform, which means the devices are
>> registered via OF and not using the legacy platform devices support.
>>
>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>> since the reported uevent MODALIAS to user-space will be the OF one.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 

Any comments about this patch? There are other two similar fixes for
watchdog drivers that were also reviewed by Guenter but never picked:

https://lkml.org/lkml/2016/10/14/412
https://lkml.org/lkml/2016/10/14/413

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [next] | [standalone]


#1533222

FromGuenter Roeck <linux@roeck-us.net>
Date2016-11-30 12:00 +0100
Message-ID<sJaMi-52Z-35@gated-at.bofh.it>
In reply to#1532369
On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote:
> Hello Wim,
>
> On 10/20/2016 07:28 PM, Guenter Roeck wrote:
>> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>>> The Amlogic Meson is a DT-only platform, which means the devices are
>>> registered via OF and not using the legacy platform devices support.
>>>
>>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>>> since the reported uevent MODALIAS to user-space will be the OF one.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>
> Any comments about this patch? There are other two similar fixes for
> watchdog drivers that were also reviewed by Guenter but never picked:
>
> https://lkml.org/lkml/2016/10/14/412
> https://lkml.org/lkml/2016/10/14/413
>
> Best regards,
>
The patches are all in my watchdog-next branch, so Wim will hopefully
pick them up for the next release.

Guenter

[toc] | [prev] | [next] | [standalone]


#1533270

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-11-30 13:50 +0100
Message-ID<sJcuK-6aW-5@gated-at.bofh.it>
In reply to#1533222
Hello Guenter,

On 11/30/2016 07:59 AM, Guenter Roeck wrote:
> On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote:
>> Hello Wim,
>>
>> On 10/20/2016 07:28 PM, Guenter Roeck wrote:
>>> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote:
>>>> The Amlogic Meson is a DT-only platform, which means the devices are
>>>> registered via OF and not using the legacy platform devices support.
>>>>
>>>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt")
>>>> since the reported uevent MODALIAS to user-space will be the OF one.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>
>> Any comments about this patch? There are other two similar fixes for
>> watchdog drivers that were also reviewed by Guenter but never picked:
>>
>> https://lkml.org/lkml/2016/10/14/412
>> https://lkml.org/lkml/2016/10/14/413
>>
>> Best regards,
>>
> The patches are all in my watchdog-next branch, so Wim will hopefully
> pick them up for the next release.
>

Great, thanks a lot for the info.
 
> Guenter
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web