Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533354 > unrolled thread
| Started by | Johan Hovold <johan@kernel.org> |
|---|---|
| First post | 2016-11-30 15:40 +0100 |
| Last post | 2016-12-02 16:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks Johan Hovold <johan@kernel.org> - 2016-11-30 15:40 +0100
Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2016-12-02 09:50 +0100
Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks David Miller <davem@davemloft.net> - 2016-12-02 16:50 +0100
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2016-11-30 15:40 +0100 |
| Subject | [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks |
| Message-ID | <sJedb-7iT-3@gated-at.bofh.it> |
This series fixes a number of issues with the stmmac-driver probe error
handling, which for example left clocks enabled after probe failures.
The final patch fixes a failure to deregister and free any fixed-link
PHYs that were registered during probe on probe errors and on driver
unbind. It also fixes a related of-node leak on late probe errors.
This series depends on the of_phy_deregister_fixed_link() helper that
was just merged to net.
As mentioned earlier, one staging driver also suffers from a similar
leak and can be fixed up once the above mentioned helper hits mainline.
Note that these patches have only been compile tested.
Johan
Johan Hovold (7):
net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe
errors
net: ethernet: stmmac: dwmac-sti: fix probe error path
net: ethernet: stmmac: dwmac-rk: fix probe error path
net: ethernet: stmmac: dwmac-generic: fix probe error path
net: ethernet: stmmac: dwmac-meson8b: fix probe error path
net: ethernet: stmmac: platform: fix outdated function header
net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks
.../net/ethernet/stmicro/stmmac/dwmac-generic.c | 17 ++++++++--
.../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 25 ++++++++++----
.../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 17 ++++++++--
drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 23 ++++++++++---
.../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 32 +++++++++++++-----
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 21 +++++++++---
.../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 39 ++++++++++++++--------
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 23 ++++++++++---
drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 19 ++++++++---
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 26 +++++++++++----
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 -
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 33 +++++++++++++++---
.../net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 ++
13 files changed, 215 insertions(+), 63 deletions(-)
--
2.7.3
[toc] | [next] | [standalone]
| From | Giuseppe CAVALLARO <peppe.cavallaro@st.com> |
|---|---|
| Date | 2016-12-02 09:50 +0100 |
| Subject | Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks |
| Message-ID | <sJRHA-1oa-11@gated-at.bofh.it> |
| In reply to | #1533354 |
On 11/30/2016 3:29 PM, Johan Hovold wrote: > This series fixes a number of issues with the stmmac-driver probe error > handling, which for example left clocks enabled after probe failures. > > The final patch fixes a failure to deregister and free any fixed-link > PHYs that were registered during probe on probe errors and on driver > unbind. It also fixes a related of-node leak on late probe errors. > > This series depends on the of_phy_deregister_fixed_link() helper that > was just merged to net. > > As mentioned earlier, one staging driver also suffers from a similar > leak and can be fixed up once the above mentioned helper hits mainline. > > Note that these patches have only been compile tested. For common and STi part: Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> thx peppe > > Johan > > > Johan Hovold (7): > net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe > errors > net: ethernet: stmmac: dwmac-sti: fix probe error path > net: ethernet: stmmac: dwmac-rk: fix probe error path > net: ethernet: stmmac: dwmac-generic: fix probe error path > net: ethernet: stmmac: dwmac-meson8b: fix probe error path > net: ethernet: stmmac: platform: fix outdated function header > net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks > > .../net/ethernet/stmicro/stmmac/dwmac-generic.c | 17 ++++++++-- > .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 25 ++++++++++---- > .../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 17 ++++++++-- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 23 ++++++++++--- > .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 32 +++++++++++++----- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 21 +++++++++--- > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 39 ++++++++++++++-------- > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 23 ++++++++++--- > drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 19 ++++++++--- > drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 26 +++++++++++---- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 - > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 33 +++++++++++++++--- > .../net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 ++ > 13 files changed, 215 insertions(+), 63 deletions(-) >
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-12-02 16:50 +0100 |
| Subject | Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks |
| Message-ID | <sJYg1-5Hd-7@gated-at.bofh.it> |
| In reply to | #1533354 |
From: Johan Hovold <johan@kernel.org> Date: Wed, 30 Nov 2016 15:29:48 +0100 > This series fixes a number of issues with the stmmac-driver probe error > handling, which for example left clocks enabled after probe failures. > > The final patch fixes a failure to deregister and free any fixed-link > PHYs that were registered during probe on probe errors and on driver > unbind. It also fixes a related of-node leak on late probe errors. > > This series depends on the of_phy_deregister_fixed_link() helper that > was just merged to net. > > As mentioned earlier, one staging driver also suffers from a similar > leak and can be fixed up once the above mentioned helper hits mainline. > > Note that these patches have only been compile tested. Series applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web