Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532547 > unrolled thread
| Started by | Florian Vaussard <florian.vaussard@gmail.com> |
|---|---|
| First post | 2016-11-29 18:20 +0100 |
| Last post | 2016-12-05 15:00 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits Florian Vaussard <florian.vaussard@gmail.com> - 2016-11-29 18:20 +0100
Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-12-01 10:50 +0100
Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits Brian Austin <brian.austin@cirrus.com> - 2016-12-01 16:00 +0100
Applied "ASoC: cs42l56: Fix misuse of regmap_update_bits" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-12-05 15:00 +0100
| From | Florian Vaussard <florian.vaussard@gmail.com> |
|---|---|
| Date | 2016-11-29 18:20 +0100 |
| Subject | [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits |
| Message-ID | <sIUet-2Xs-19@gated-at.bofh.it> |
Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform (mask & 1), which results in 0 if LSB of mask is 0. Thus the call regmap_update_bits(..., mask, 1) is in reality equivalent to regmap_update_bits(..., mask, 0). In such a case, the correct use is regmap_update_bits(..., mask, mask). This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it consistent with the API. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> --- sound/soc/codecs/cs42l56.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 3e2c046..cb6ca85 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1277,19 +1277,23 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, if (cs42l56->pdata.ain1a_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN1A_REF_MASK, 1); + CS42L56_AIN1A_REF_MASK, + CS42L56_AIN1A_REF_MASK); if (cs42l56->pdata.ain1b_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN1B_REF_MASK, 1); + CS42L56_AIN1B_REF_MASK, + CS42L56_AIN1B_REF_MASK); if (cs42l56->pdata.ain2a_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN2A_REF_MASK, 1); + CS42L56_AIN2A_REF_MASK, + CS42L56_AIN2A_REF_MASK); if (cs42l56->pdata.ain2b_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN2B_REF_MASK, 1); + CS42L56_AIN2B_REF_MASK, + CS42L56_AIN2B_REF_MASK); if (cs42l56->pdata.micbias_lvl) regmap_update_bits(cs42l56->regmap, CS42L56_GAIN_BIAS_CTL, -- 2.5.5
[toc] | [next] | [standalone]
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2016-12-01 10:50 +0100 |
| Subject | Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits |
| Message-ID | <sJwa6-26V-15@gated-at.bofh.it> |
| In reply to | #1532547 |
On Tue, Nov 29, 2016 at 06:10:49PM +0100, Florian Vaussard wrote: > Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) > and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform > (mask & 1), which results in 0 if LSB of mask is 0. Thus the call > regmap_update_bits(..., mask, 1) is in reality equivalent to > regmap_update_bits(..., mask, 0). > > In such a case, the correct use is regmap_update_bits(..., mask, mask). > > This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK > masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it > consistent with the API. Please note that this change is untested, > as I do not have this piece of hardware. Testers are welcome! > > Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> > --- Looks good to me: Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
[toc] | [prev] | [next] | [standalone]
| From | Brian Austin <brian.austin@cirrus.com> |
|---|---|
| Date | 2016-12-01 16:00 +0100 |
| Subject | Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits |
| Message-ID | <sJB05-5a9-3@gated-at.bofh.it> |
| In reply to | #1533931 |
On Thu, 1 Dec 2016, Charles Keepax wrote: > On Tue, Nov 29, 2016 at 06:10:49PM +0100, Florian Vaussard wrote: > > Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) > > and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform > > (mask & 1), which results in 0 if LSB of mask is 0. Thus the call > > regmap_update_bits(..., mask, 1) is in reality equivalent to > > regmap_update_bits(..., mask, 0). > > > > In such a case, the correct use is regmap_update_bits(..., mask, mask). > > > > This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK > > masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it > > consistent with the API. Please note that this change is untested, > > as I do not have this piece of hardware. Testers are welcome! > > > > Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> > > --- > > Looks good to me: > > Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > > Thanks, > Charles > Acked-by: Brian Austin <brian.austin@cirrus.com> Thanks, Brian
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-12-05 15:00 +0100 |
| Subject | Applied "ASoC: cs42l56: Fix misuse of regmap_update_bits" to the asoc tree |
| Message-ID | <sL1Yi-5fD-19@gated-at.bofh.it> |
| In reply to | #1532547 |
The patch ASoC: cs42l56: Fix misuse of regmap_update_bits has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 8c317fafdd4e3b988c44d986022c66cebf71fc41 Mon Sep 17 00:00:00 2001 From: Florian Vaussard <florian.vaussard@gmail.com> Date: Tue, 29 Nov 2016 18:10:49 +0100 Subject: [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform (mask & 1), which results in 0 if LSB of mask is 0. Thus the call regmap_update_bits(..., mask, 1) is in reality equivalent to regmap_update_bits(..., mask, 0). In such a case, the correct use is regmap_update_bits(..., mask, mask). This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it consistent with the API. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch> Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Acked-by: Brian Austin <brian.austin@cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/cs42l56.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 3e2c04642f1e..cb6ca85f1536 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1277,19 +1277,23 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, if (cs42l56->pdata.ain1a_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN1A_REF_MASK, 1); + CS42L56_AIN1A_REF_MASK, + CS42L56_AIN1A_REF_MASK); if (cs42l56->pdata.ain1b_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN1B_REF_MASK, 1); + CS42L56_AIN1B_REF_MASK, + CS42L56_AIN1B_REF_MASK); if (cs42l56->pdata.ain2a_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN2A_REF_MASK, 1); + CS42L56_AIN2A_REF_MASK, + CS42L56_AIN2A_REF_MASK); if (cs42l56->pdata.ain2b_ref_cfg) regmap_update_bits(cs42l56->regmap, CS42L56_AIN_REFCFG_ADC_MUX, - CS42L56_AIN2B_REF_MASK, 1); + CS42L56_AIN2B_REF_MASK, + CS42L56_AIN2B_REF_MASK); if (cs42l56->pdata.micbias_lvl) regmap_update_bits(cs42l56->regmap, CS42L56_GAIN_BIAS_CTL, -- 2.10.2
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web