Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531042 > unrolled thread
| Started by | Haishuang Yan <yanhaishuang@cmss.chinamobile.com> |
|---|---|
| First post | 2016-11-28 06:30 +0100 |
| Last post | 2016-11-28 22:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel. Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2016-11-28 06:30 +0100
Re: [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel. Pravin Shelar <pshelar@ovn.org> - 2016-11-28 07:00 +0100
Re: [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel. David Miller <davem@davemloft.net> - 2016-11-28 22:20 +0100
| From | Haishuang Yan <yanhaishuang@cmss.chinamobile.com> |
|---|---|
| Date | 2016-11-28 06:30 +0100 |
| Subject | [PATCH] geneve: fix ip_hdr_len reserved for geneve6 tunnel. |
| Message-ID | <sImFP-6cg-7@gated-at.bofh.it> |
It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
---
drivers/net/geneve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 7b80e28..45301cb 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -852,7 +852,7 @@ static int geneve6_xmit_skb(struct sk_buff *skb, struct net_device *dev,
ip_hdr(skb), skb);
ttl = key->ttl ? : ip6_dst_hoplimit(dst);
}
- err = geneve_build_skb(dst, skb, info, xnet, sizeof(struct iphdr));
+ err = geneve_build_skb(dst, skb, info, xnet, sizeof(struct ipv6hdr));
if (unlikely(err))
return err;
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Pravin Shelar <pshelar@ovn.org> |
|---|---|
| Date | 2016-11-28 07:00 +0100 |
| Message-ID | <sIn8S-6mn-7@gated-at.bofh.it> |
| In reply to | #1531042 |
On Sun, Nov 27, 2016 at 9:26 PM, Haishuang Yan
<yanhaishuang@cmss.chinamobile.com> wrote:
> It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
>
> Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Thanks for fix.
Acked-by: Pravin B Shelar <pshelar@ovn.org>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-11-28 22:20 +0100 |
| Message-ID | <sIBvc-7oU-59@gated-at.bofh.it> |
| In reply to | #1531042 |
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Mon, 28 Nov 2016 13:26:58 +0800
> It shold reserved sizeof(ipv6hdr) for geneve in ipv6 tunnel.
>
> Fixes: c3ef5aa5e5 ('geneve: Merge ipv4 and ipv6 geneve_build_skb()')
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web