Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1532396 > unrolled thread

Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-11-29 16:10 +0100
Last post2016-11-29 16:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] leds: netxbig: fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-29 16:10 +0100
    Re: [PATCH] leds: netxbig: fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-29 16:40 +0100
    Re: [PATCH] leds: netxbig: fix module autoload for OF registration Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-29 16:40 +0100

#1532396 — Re: [PATCH] leds: netxbig: fix module autoload for OF registration

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-11-29 16:10 +0100
SubjectRe: [PATCH] leds: netxbig: fix module autoload for OF registration
Message-ID<sIScH-1DN-53@gated-at.bofh.it>
Hello Jacek,

On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias:          platform:leds-netxbig
> 
> After this patch:
> 
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias:          platform:leds-netxbig
> alias:          of:N*T*Clacie,netxbig-ledsC*
> alias:          of:N*T*Clacie,netxbig-leds
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [next] | [standalone]


#1532430

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-11-29 16:40 +0100
Message-ID<sISFI-1NU-25@gated-at.bofh.it>
In reply to#1532396
Hello Jacek,

On 11/29/2016 12:34 PM, Jacek Anaszewski wrote:
> Hi Javier,
> 
> On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
>> Hello Jacek,
>>
>> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias:          platform:leds-netxbig
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias:          platform:leds-netxbig
>>> alias:          of:N*T*Clacie,netxbig-ledsC*
>>> alias:          of:N*T*Clacie,netxbig-leds
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> ---
>>>
>>
>> Any comments about this patch?
> 
> I mistakenly marked it as merged. Sorry about that.
> Applied to the for-next branch of linux-leds.git.
> 

Great, thanks for the information.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]


#1532431

FromJacek Anaszewski <j.anaszewski@samsung.com>
Date2016-11-29 16:40 +0100
Message-ID<sISFI-1NU-29@gated-at.bofh.it>
In reply to#1532396
Hi Javier,

On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
> Hello Jacek,
>
> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias:          platform:leds-netxbig
>>
>> After this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias:          platform:leds-netxbig
>> alias:          of:N*T*Clacie,netxbig-ledsC*
>> alias:          of:N*T*Clacie,netxbig-leds
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>
> Any comments about this patch?

I mistakenly marked it as merged. Sorry about that.
Applied to the for-next branch of linux-leds.git.

-- 
Best regards,
Jacek Anaszewski

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web