Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530861 > unrolled thread

Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi

Started byJonathan Cameron <jic23@kernel.org>
First post2016-11-27 12:20 +0100
Last post2016-11-30 18:30 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi Jonathan Cameron <jic23@kernel.org> - 2016-11-27 12:20 +0100
    Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-11-29 05:30 +0100
      Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi Linus Walleij <linus.walleij@linaro.org> - 2016-11-30 14:10 +0100
      Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2016-11-30 18:30 +0100

#1530861 — Re: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi

FromJonathan Cameron <jic23@kernel.org>
Date2016-11-27 12:20 +0100
SubjectRe: [PATCH 3/3] iio: st_pressure: Support i2c probe using acpi
Message-ID<sI5F0-3AT-13@gated-at.bofh.it>
On 24/11/16 14:28, Linus Walleij wrote:
> On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
> <shrirang.bagul@canonical.com> wrote:
> 
>> Compatible strings are not available on ACPI based systems. This patch adds
>> support to use DSDT information read from platform BIOS instead for probing
>> st pressure sensors.
>>
>> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> (...)
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id st_press_acpi_match[] = {
>> +       {"SNO9210", LPS22HB},
>> +       { },
>> +};
> 
> Same comment. One sensor only supported by ACPI really?
As demonstrated by this one, they are often registered under effectively random names!
Digging out those random names and associating them with a particular chip is always
going to be a non trivial job.

Hence I'm happy to take these as they stand.  We can add more entries when we come
across them.
> 
> Take a wider look.
Shirang has done a good job identifying this one and sending it upstream.
Be nice Linus and don't try to get him to do all the hard work ;)

As such applied to the togreg branch of iio.git. Will be pushed out as testing for
the autobuilders to play with it.

Note there will be some weeks before I push this out as togreg (given merge window
is about to open) so plenty of time for others to take a look!

Thanks,

Jonathan
> 
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[toc] | [next] | [standalone]


#1531891

FromShrirang Bagul <shrirang.bagul@canonical.com>
Date2016-11-29 05:30 +0100
Message-ID<sIIdj-3os-5@gated-at.bofh.it>
In reply to#1530861
On Sun, 2016-11-27 at 11:12 +0000, Jonathan Cameron wrote:
> On 24/11/16 14:28, Linus Walleij wrote:
> > On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
> > <shrirang.bagul@canonical.com> wrote:
> > 
> > > Compatible strings are not available on ACPI based systems. This patch
> > > adds
> > > support to use DSDT information read from platform BIOS instead for
> > > probing
> > > st pressure sensors.
> > > 
> > > Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> > 
> > (...)
> > > +#ifdef CONFIG_ACPI
> > > +static const struct acpi_device_id st_press_acpi_match[] = {
> > > +       {"SNO9210", LPS22HB},
> > > +       { },
> > > +};
> > 
> > Same comment. One sensor only supported by ACPI really?
> 
> As demonstrated by this one, they are often registered under effectively
> random names!
> Digging out those random names and associating them with a particular chip is
> always
> going to be a non trivial job.
> 
> Hence I'm happy to take these as they stand.  We can add more entries when we
> come
> across them.
> > 
> > Take a wider look.
Yes, I will.
> 
> Shirang has done a good job identifying this one and sending it upstream.
> Be nice Linus and don't try to get him to do all the hard work ;)
> 
> As such applied to the togreg branch of iio.git. Will be pushed out as testing
> for
> the autobuilders to play with it.
> 
> Note there will be some weeks before I push this out as togreg (given merge
> window
> is about to open) so plenty of time for others to take a look!
> 
> Thanks,
> 
> Jonathan
Thank you Jonathan. I'll follow-up on Linus's suggestion and try and identify
more of these sensors on some of the hardware we have in the lab. and try to add
support for some more devices.

Thanks,
Shrirang
> > 
> > Yours,
> > Linus Walleij
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 

[toc] | [prev] | [next] | [standalone]


#1533284

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-11-30 14:10 +0100
Message-ID<sJcO6-6wi-17@gated-at.bofh.it>
In reply to#1531891
On Tue, Nov 29, 2016 at 5:25 AM, Shrirang Bagul
<shrirang.bagul@canonical.com> wrote:

> Thank you Jonathan. I'll follow-up on Linus's suggestion and try and identify
> more of these sensors on some of the hardware we have in the lab. and try to add
> support for some more devices.

Thanks Shrirang, appreciated!

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]


#1533460

FromJonathan Cameron <jic23@jic23.retrosnub.co.uk>
Date2016-11-30 18:30 +0100
Message-ID<sJgRI-yy-5@gated-at.bofh.it>
In reply to#1531891

On 29 November 2016 04:25:03 GMT+00:00, Shrirang Bagul <shrirang.bagul@canonical.com> wrote:
>On Sun, 2016-11-27 at 11:12 +0000, Jonathan Cameron wrote:
>> On 24/11/16 14:28, Linus Walleij wrote:
>> > On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
>> > <shrirang.bagul@canonical.com> wrote:
>> > 
>> > > Compatible strings are not available on ACPI based systems. This
>patch
>> > > adds
>> > > support to use DSDT information read from platform BIOS instead
>for
>> > > probing
>> > > st pressure sensors.
>> > > 
>> > > Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
>> > 
>> > (...)
>> > > +#ifdef CONFIG_ACPI
>> > > +static const struct acpi_device_id st_press_acpi_match[] = {
>> > > +       {"SNO9210", LPS22HB},
>> > > +       { },
>> > > +};
>> > 
>> > Same comment. One sensor only supported by ACPI really?
>> 
>> As demonstrated by this one, they are often registered under
>effectively
>> random names!
>> Digging out those random names and associating them with a particular
>chip is
>> always
>> going to be a non trivial job.
>> 
>> Hence I'm happy to take these as they stand.  We can add more entries
>when we
>> come
>> across them.
>> > 
>> > Take a wider look.
>Yes, I will.
>> 
>> Shirang has done a good job identifying this one and sending it
>upstream.
>> Be nice Linus and don't try to get him to do all the hard work ;)
>> 
>> As such applied to the togreg branch of iio.git. Will be pushed out
>as testing
>> for
>> the autobuilders to play with it.
>> 
>> Note there will be some weeks before I push this out as togreg (given
>merge
>> window
>> is about to open) so plenty of time for others to take a look!
>> 
>> Thanks,
>> 
>> Jonathan
>Thank you Jonathan. I'll follow-up on Linus's suggestion and try and
>identify
>more of these sensors on some of the hardware we have in the lab. and
>try to add
>support for some more devices.
Great! Thanks for looking into this.

J
>
>Thanks,
>Shrirang
>> > 
>> > Yours,
>> > Linus Walleij
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>linux-iio" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> > 
>> 
>> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web