Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1529850 > unrolled thread

[PATCH] regulator: twl: drop of_match_ptr

Started byNicolae Rosia <Nicolae_Rosia@mentor.com>
First post2016-11-25 08:50 +0100
Last post2016-11-25 14:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] regulator: twl: drop of_match_ptr Nicolae Rosia <Nicolae_Rosia@mentor.com> - 2016-11-25 08:50 +0100
    Re: [PATCH] regulator: twl: drop of_match_ptr Mark Brown <broonie@kernel.org> - 2016-11-25 14:10 +0100

#1529850 — [PATCH] regulator: twl: drop of_match_ptr

FromNicolae Rosia <Nicolae_Rosia@mentor.com>
Date2016-11-25 08:50 +0100
Subject[PATCH] regulator: twl: drop of_match_ptr
Message-ID<sHjqF-65B-11@gated-at.bofh.it>
We can safely drop of_match_ptr since the driver
depends on CONFIG_OF symbol

Signed-off-by: Nicolae Rosia <Nicolae_Rosia@mentor.com>
---
Depends on "regulator: twl6030: add dependency on OF".
After sending that one I realised that twl-regulator can also
have that change. You can squash these two if you like.

 drivers/regulator/twl-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 6c9ec84..48c060f 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -654,7 +654,7 @@ static struct platform_driver twlreg_driver = {
 	 */
 	.driver  = {
 		.name  = "twl4030_reg",
-		.of_match_table = of_match_ptr(twl_of_match),
+		.of_match_table = twl_of_match,
 	},
 };
 
-- 
2.9.3

[toc] | [next] | [standalone]


#1530212

FromMark Brown <broonie@kernel.org>
Date2016-11-25 14:10 +0100
Message-ID<sHoqm-YR-63@gated-at.bofh.it>
In reply to#1529850

[Multipart message — attachments visible in raw view] — view raw

On Fri, Nov 25, 2016 at 09:49:00AM +0200, Nicolae Rosia wrote:
> We can safely drop of_match_ptr since the driver
> depends on CONFIG_OF symbol

As with the previous patch I see no benefit here.  What's the reason for
doing this?

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web