Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530094 > unrolled thread

[PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3

Started byBenjamin Tissoires <benjamin.tissoires@redhat.com>
First post2016-11-25 11:20 +0100
Last post2016-11-25 14:10 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 11:20 +0100
    Re: [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3 Bastien Nocera <hadess@hadess.net> - 2016-11-25 13:20 +0100
      Re: [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-25 14:10 +0100

#1530094 — [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3

FromBenjamin Tissoires <benjamin.tissoires@redhat.com>
Date2016-11-25 11:20 +0100
Subject[PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3
Message-ID<sHlLQ-7Jm-13@gated-at.bofh.it>
One more device requiring a quirk :/

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-sensor-hub.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 50aad26..f9440b6 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -798,6 +798,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_MICROSOFT,
 			USB_DEVICE_ID_MS_TYPE_COVER_2),
 			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_MICROSOFT,
+			0x07bd), /* Microsoft Surface 3 TypeCover */
+			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_STM_0,
 			USB_DEVICE_ID_STM_HID_SENSOR),
 			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
-- 
2.7.4

[toc] | [next] | [standalone]


#1530159

FromBastien Nocera <hadess@hadess.net>
Date2016-11-25 13:20 +0100
Message-ID<sHnDX-t4-7@gated-at.bofh.it>
In reply to#1530094
On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote:
> One more device requiring a quirk :/
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Tested-by: Bastien Nocera <hadess@hadess.net>

> ---
>  drivers/hid/hid-sensor-hub.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-
> hub.c
> index 50aad26..f9440b6 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -798,6 +798,9 @@ static const struct hid_device_id
> sensor_hub_devices[] = {
>  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_MICROSOFT,
>  			USB_DEVICE_ID_MS_TYPE_COVER_2),
>  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> +	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_MICROSOFT,
> +			0x07bd), /* Microsoft Surface 3 TypeCover */

The sensor is not in the TypeCover though, it's in the main device.

> +			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
>  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_STM_0,
>  			USB_DEVICE_ID_STM_HID_SENSOR),
>  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},

[toc] | [prev] | [next] | [standalone]


#1530206

FromBenjamin Tissoires <benjamin.tissoires@redhat.com>
Date2016-11-25 14:10 +0100
Message-ID<sHoql-YR-15@gated-at.bofh.it>
In reply to#1530159
On Nov 25 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote:
> > One more device requiring a quirk :/
> > 
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> Tested-by: Bastien Nocera <hadess@hadess.net>
> 
> > ---
> >  drivers/hid/hid-sensor-hub.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-
> > hub.c
> > index 50aad26..f9440b6 100644
> > --- a/drivers/hid/hid-sensor-hub.c
> > +++ b/drivers/hid/hid-sensor-hub.c
> > @@ -798,6 +798,9 @@ static const struct hid_device_id
> > sensor_hub_devices[] = {
> >  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_MICROSOFT,
> >  			USB_DEVICE_ID_MS_TYPE_COVER_2),
> >  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> > +	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_MICROSOFT,
> > +			0x07bd), /* Microsoft Surface 3 TypeCover */
> 
> The sensor is not in the TypeCover though, it's in the main device.

Oops, yes, sorry. I have been traumatised by the type cover apparently
:)

Benjamin

> 
> > +			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> >  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> > USB_VENDOR_ID_STM_0,
> >  			USB_DEVICE_ID_STM_HID_SENSOR),
> >  			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web