Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1526085 > unrolled thread
| Started by | Walt Feasel <waltfeasel@gmail.com> |
|---|---|
| First post | 2016-11-19 18:40 +0100 |
| Last post | 2016-11-25 14:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 1/5] staging: speakup: synth.c Spaces around operators Walt Feasel <waltfeasel@gmail.com> - 2016-11-19 18:40 +0100
[PATCH v3 1/5] staging: speakup: synth.c Spaces around operators Walt Feasel <waltfeasel@gmail.com> - 2016-11-19 20:40 +0100
Re: [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-25 14:20 +0100
| From | Walt Feasel <waltfeasel@gmail.com> |
|---|---|
| Date | 2016-11-19 18:40 +0100 |
| Subject | [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators |
| Message-ID | <sFhMm-7VK-11@gated-at.bofh.it> |
Make suggested checkpatch modification for
CHECK: spaces preferred around that '+,|,-,/'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/synth.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 54b2f39..9c73a33 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -1,4 +1,4 @@
-#include <linux/types.h>
+w#include <linux/types.h>
#include <linux/ctype.h> /* for isdigit() and friends */
#include <linux/fs.h>
#include <linux/mm.h> /* for verify_area */
@@ -303,11 +303,11 @@ void spk_get_index_count(int *linecount, int *sentcount)
sentence_count = ind % 10;
if ((ind / 10) <= synth->indexing.currindex)
- index_count = synth->indexing.currindex-(ind/10);
+ index_count = synth->indexing.currindex - (ind / 10);
else
index_count = synth->indexing.currindex
- -synth->indexing.lowindex
- + synth->indexing.highindex-(ind/10)+1;
+ - synth->indexing.lowindex
+ + synth->indexing.highindex - (ind / 10) + 1;
}
*sentcount = sentence_count;
@@ -476,10 +476,10 @@ void synth_remove(struct spk_synth *in_synth)
break;
}
for ( ; synths[i] != NULL; i++) /* compress table */
- synths[i] = synths[i+1];
+ synths[i] = synths[i + 1];
module_status = 0;
mutex_unlock(&spk_mutex);
}
EXPORT_SYMBOL_GPL(synth_remove);
-short spk_punc_masks[] = { 0, SOME, MOST, PUNC, PUNC|B_SYM };
+short spk_punc_masks[] = { 0, SOME, MOST, PUNC, PUNC | B_SYM };
--
2.1.4
[toc] | [next] | [standalone]
| From | Walt Feasel <waltfeasel@gmail.com> |
|---|---|
| Date | 2016-11-19 20:40 +0100 |
| Subject | [PATCH v3 1/5] staging: speakup: synth.c Spaces around operators |
| Message-ID | <sFjEt-Ip-7@gated-at.bofh.it> |
| In reply to | #1526085 |
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|,+,-,/'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
v3 fixes erroneous w added in v2
drivers/staging/speakup/synth.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 54b2f39..17aa440 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -303,11 +303,11 @@ void spk_get_index_count(int *linecount, int *sentcount)
sentence_count = ind % 10;
if ((ind / 10) <= synth->indexing.currindex)
- index_count = synth->indexing.currindex-(ind/10);
+ index_count = synth->indexing.currindex - (ind / 10);
else
index_count = synth->indexing.currindex
- -synth->indexing.lowindex
- + synth->indexing.highindex-(ind/10)+1;
+ - synth->indexing.lowindex
+ + synth->indexing.highindex - (ind / 10) + 1;
}
*sentcount = sentence_count;
@@ -476,10 +476,10 @@ void synth_remove(struct spk_synth *in_synth)
break;
}
for ( ; synths[i] != NULL; i++) /* compress table */
- synths[i] = synths[i+1];
+ synths[i] = synths[i + 1];
module_status = 0;
mutex_unlock(&spk_mutex);
}
EXPORT_SYMBOL_GPL(synth_remove);
-short spk_punc_masks[] = { 0, SOME, MOST, PUNC, PUNC|B_SYM };
+short spk_punc_masks[] = { 0, SOME, MOST, PUNC, PUNC | B_SYM };
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-11-25 14:20 +0100 |
| Message-ID | <sHoA2-129-29@gated-at.bofh.it> |
| In reply to | #1526085 |
On Sat, Nov 19, 2016 at 12:35:43PM -0500, Walt Feasel wrote: > Make suggested checkpatch modification for > CHECK: spaces preferred around that '+,|,-,/' > > Signed-off-by: Walt Feasel <waltfeasel@gmail.com> > --- > v2 makes changes to correct for email format patch submission > > drivers/staging/speakup/synth.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c > index 54b2f39..9c73a33 100644 > --- a/drivers/staging/speakup/synth.c > +++ b/drivers/staging/speakup/synth.c > @@ -1,4 +1,4 @@ > -#include <linux/types.h> > +w#include <linux/types.h> This is a mistake. regards, dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web