Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1530788 > unrolled thread
| Started by | Peter Foley <pefoley2@pefoley.com> |
|---|---|
| First post | 2016-11-26 23:30 +0100 |
| Last post | 2016-11-28 08:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Annotate die() with noreturn Peter Foley <pefoley2@pefoley.com> - 2016-11-26 23:30 +0100
[tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang tip-bot for Peter Foley <tipbot@zytor.com> - 2016-11-28 08:30 +0100
| From | Peter Foley <pefoley2@pefoley.com> |
|---|---|
| Date | 2016-11-26 23:30 +0100 |
| Subject | [PATCH] Annotate die() with noreturn |
| Message-ID | <sHTDQ-47v-13@gated-at.bofh.it> |
Fixes below warning with clang:
In file included from ../arch/x86/tools/relocs_64.c:17: ../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!use_real_mode)
^~~~~~~~~~~~~~ ../arch/x86/tools/relocs.c:989:14: note: uninitialized use occurs here walk_relocs(do_reloc); ^~~~~~~~ ../arch/x86/tools/relocs.c:977:2: note: remove the 'if' if its condition is always true
if (!use_real_mode)
^~~~~~~~~~~~~~~~~~~
../arch/x86/tools/relocs.c:974:24: note: initialize the variable 'do_reloc' to silence this warning
const char *symname);
^
= NULL
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
arch/x86/tools/relocs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h
index f59590645b68..1d23bf953a4a 100644
--- a/arch/x86/tools/relocs.h
+++ b/arch/x86/tools/relocs.h
@@ -16,7 +16,7 @@
#include <regex.h>
#include <tools/le_byteshift.h>
-void die(char *fmt, ...);
+void die(char *fmt, ...) __attribute__((noreturn));
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
--
2.11.0.rc2
[toc] | [next] | [standalone]
| From | tip-bot for Peter Foley <tipbot@zytor.com> |
|---|---|
| Date | 2016-11-28 08:30 +0100 |
| Subject | [tip:x86/urgent] x86/build: Annotate die() with noreturn to fix build warning on clang |
| Message-ID | <sIoxY-7ud-19@gated-at.bofh.it> |
| In reply to | #1530788 |
Commit-ID: adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Gitweb: http://git.kernel.org/tip/adee8705d2517f0e163ffc45e8d7f9e97a58f1f6 Author: Peter Foley <pefoley2@pefoley.com> AuthorDate: Sat, 26 Nov 2016 17:22:29 -0500 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 28 Nov 2016 07:47:22 +0100 x86/build: Annotate die() with noreturn to fix build warning on clang Fixes below warning with clang: In file included from ../arch/x86/tools/relocs_64.c:17: ../arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] Signed-off-by: Peter Foley <pefoley2@pefoley.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161126222229.673-1-pefoley2@pefoley.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/tools/relocs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/tools/relocs.h b/arch/x86/tools/relocs.h index f595906..1d23bf9 100644 --- a/arch/x86/tools/relocs.h +++ b/arch/x86/tools/relocs.h @@ -16,7 +16,7 @@ #include <regex.h> #include <tools/le_byteshift.h> -void die(char *fmt, ...); +void die(char *fmt, ...) __attribute__((noreturn)); #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web