Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1530666 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2016-11-26 14:20 +0100 |
| Last post | 2016-12-09 13:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Pavel Machek <pavel@ucw.cz> - 2016-11-26 14:20 +0100
Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Thomas Gleixner <tglx@linutronix.de> - 2016-11-26 14:30 +0100
RE: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> - 2016-12-09 13:50 +0100
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2016-11-26 14:20 +0100 |
| Subject | Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot |
| Message-ID | <sHL3z-74K-5@gated-at.bofh.it> |
On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > +#ifdef CONFIG_X86_64
> > +static int phi_r3mwait_disabled __read_mostly;
> > +
> > +static int __init phir3mwait_disable(char *__unused)
> > +{
> > + phi_r3mwait_disabled = 1;
> > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
>
> Why would that be a warning? The sysadmin added the command line switch, so
> why does he needs to be warned?
Its telling admin he did not make a typo on the command line. We often do that....
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2016-11-26 14:30 +0100 |
| Message-ID | <sHLdf-77O-3@gated-at.bofh.it> |
| In reply to | #1530666 |
On Sat, 26 Nov 2016, Pavel Machek wrote:
> On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > +#ifdef CONFIG_X86_64
> > > +static int phi_r3mwait_disabled __read_mostly;
> > > +
> > > +static int __init phir3mwait_disable(char *__unused)
> > > +{
> > > + phi_r3mwait_disabled = 1;
> > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> >
> > Why would that be a warning? The sysadmin added the command line switch, so
> > why does he needs to be warned?
>
> Its telling admin he did not make a typo on the command line. We often do that....
Definitely not at the warning level.
[toc] | [prev] | [next] | [standalone]
| From | "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> |
|---|---|
| Date | 2016-12-09 13:50 +0100 |
| Message-ID | <sMsMF-3hS-1@gated-at.bofh.it> |
| In reply to | #1530668 |
> > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > +#ifdef CONFIG_X86_64
> > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > +
> > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > + phi_r3mwait_disabled = 1;
> > > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > >
> > > Why would that be a warning? The sysadmin added the command line
> > > switch, so why does he needs to be warned?
> >
> > Its telling admin he did not make a typo on the command line. We often do that....
>
> Definitely not at the warning level.
Is info level OK for that message?
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web