Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1529173 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-11-24 12:10 +0100 |
| Last post | 2016-11-24 16:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] net/mlx5: remove a duplicate condition Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-24 12:10 +0100
Re: [patch] net/mlx5: remove a duplicate condition Saeed Mahameed <saeedm@dev.mellanox.co.il> - 2016-11-24 16:50 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-11-24 12:10 +0100 |
| Subject | [patch] net/mlx5: remove a duplicate condition |
| Message-ID | <sH04F-1RN-9@gated-at.bofh.it> |
We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first line of the function so we don't need to check again here. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Not a bugfix so it would go into -next diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c index 68ec4ea..a263d89 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c @@ -1307,8 +1307,7 @@ static bool counter_is_valid(struct mlx5_fc *counter, u32 action) return false; return (action & (MLX5_FLOW_CONTEXT_ACTION_DROP | - MLX5_FLOW_CONTEXT_ACTION_FWD_DEST)) && - (action & MLX5_FLOW_CONTEXT_ACTION_COUNT); + MLX5_FLOW_CONTEXT_ACTION_FWD_DEST)); } static bool dest_is_valid(struct mlx5_flow_destination *dest,
[toc] | [next] | [standalone]
| From | Saeed Mahameed <saeedm@dev.mellanox.co.il> |
|---|---|
| Date | 2016-11-24 16:50 +0100 |
| Message-ID | <sH4rD-4E0-17@gated-at.bofh.it> |
| In reply to | #1529173 |
On Thu, Nov 24, 2016 at 1:03 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first > line of the function so we don't need to check again here. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Saeed Mahameed <saeedm@mellanox.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web