Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1529057 > unrolled thread

[PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function

Back to article view | Back to linux.kernel

Contents

  [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 09:30 +0100
    Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work()  function Ingo Molnar <mingo@kernel.org> - 2016-11-24 09:50 +0100
      Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-24 22:10 +0100

#1529057 — [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function

This patch rectifies a comment present in sugov_irq_work() function to
follow proper grammar.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/sched/cpufreq_schedutil.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 42a220e78f00..71e1a980d40a 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
 	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
 
 	/*
-	 * For Real Time and Deadline tasks, schedutil governor shoots the
-	 * frequency to maximum. And special care must be taken to ensure that
-	 * this kthread doesn't result in that.
+	 * For Real Time and Deadline tasks, the schedutil governor shoots the
+	 * frequency to maximum. Special care must be taken to ensure that this
+	 * kthread doesn't result in the same behavior.
 	 *
 	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
-	 * updated only at the end of the sugov_work() and before that schedutil
-	 * rejects all other frequency scaling requests.
+	 * updated only at the end of the sugov_work() function and before that
+	 * the schedutil governor rejects all other frequency scaling requests.
 	 *
-	 * Though there is a very rare case where the RT thread yields right
+	 * There is a very rare case though, where the RT thread yields right
 	 * after the work_in_progress flag is cleared. The effects of that are
 	 * neglected for now.
 	 */
-- 
2.7.1.410.g6faf27b

[toc] | [next] | [standalone]

#1529069 — Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function

* Viresh Kumar <viresh.kumar@linaro.org> wrote:

> This patch rectifies a comment present in sugov_irq_work() function to
> follow proper grammar.
> 
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  kernel/sched/cpufreq_schedutil.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 42a220e78f00..71e1a980d40a 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
>  	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
>  
>  	/*
> +	 * For Real Time and Deadline tasks, the schedutil governor shoots the
> +	 * frequency to maximum. Special care must be taken to ensure that this
> +	 * kthread doesn't result in the same behavior.
>  	 *
>  	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> +	 * updated only at the end of the sugov_work() function and before that
> +	 * the schedutil governor rejects all other frequency scaling requests.
>  	 *
> +	 * There is a very rare case though, where the RT thread yields right
>  	 * after the work_in_progress flag is cleared. The effects of that are
>  	 * neglected for now.
>  	 */

Also:

  s/Real Time task/RT task
  s/Deadline task/deadline task

With those:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1529704

On Thu, Nov 24, 2016 at 9:45 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
>> This patch rectifies a comment present in sugov_irq_work() function to
>> follow proper grammar.
>>
>> Suggested-by: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>>  kernel/sched/cpufreq_schedutil.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
>> index 42a220e78f00..71e1a980d40a 100644
>> --- a/kernel/sched/cpufreq_schedutil.c
>> +++ b/kernel/sched/cpufreq_schedutil.c
>> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
>>       sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
>>
>>       /*
>> +      * For Real Time and Deadline tasks, the schedutil governor shoots the
>> +      * frequency to maximum. Special care must be taken to ensure that this
>> +      * kthread doesn't result in the same behavior.
>>        *
>>        * This is (mostly) guaranteed by the work_in_progress flag. The flag is
>> +      * updated only at the end of the sugov_work() function and before that
>> +      * the schedutil governor rejects all other frequency scaling requests.
>>        *
>> +      * There is a very rare case though, where the RT thread yields right
>>        * after the work_in_progress flag is cleared. The effects of that are
>>        * neglected for now.
>>        */
>
> Also:
>
>   s/Real Time task/RT task
>   s/Deadline task/deadline task
>
> With those:
>
>   Acked-by: Ingo Molnar <mingo@kernel.org>
>

Fixed up and applied.

Thanks,
Rafael

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web