Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522584 > unrolled thread

[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

Started byBartosz Golaszewski <bgolaszewski@baylibre.com>
First post2016-11-15 12:10 +0100
Last post2016-11-24 09:50 +0100
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-15 12:10 +0100
    Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Sekhar Nori <nsekhar@ti.com> - 2016-11-16 10:20 +0100
    Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes David Lechner <david@lechnology.com> - 2016-11-22 23:30 +0100
      Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-23 11:40 +0100
        Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes David Lechner <david@lechnology.com> - 2016-11-23 17:30 +0100
          Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Kevin Hilman <khilman@baylibre.com> - 2016-11-23 23:40 +0100
            Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes David Lechner <david@lechnology.com> - 2016-11-23 23:50 +0100
              Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Sekhar Nori <nsekhar@ti.com> - 2016-11-24 06:10 +0100
                Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-24 09:50 +0100

#1522584 — [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

FromBartosz Golaszewski <bgolaszewski@baylibre.com>
Date2016-11-15 12:10 +0100
Subject[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes
Message-ID<sDJMK-49e-25@gated-at.bofh.it>
Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
controller drivers to da850.dtsi.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
v1 -> v2:
- moved the priority controller node above the cfgchip node
- renamed added nodes to better reflect their purpose

 arch/arm/boot/dts/da850.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 1bb1f6d..412eec6 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -210,6 +210,10 @@
 			};
 
 		};
+		prictrl: priority-controller@14110 {
+			compatible = "ti,da850-mstpri";
+			reg = <0x14110 0x0c>;
+		};
 		cfgchip: chip-controller@1417c {
 			compatible = "ti,da830-cfgchip", "syscon", "simple-mfd";
 			reg = <0x1417c 0x14>;
@@ -451,4 +455,8 @@
 			  1 0 0x68000000 0x00008000>;
 		status = "disabled";
 	};
+	memctrl: memory-controller@b0000000 {
+		compatible = "ti,da850-ddr-controller";
+		reg = <0xb0000000 0xe8>;
+	};
 };
-- 
2.9.3

[toc] | [next] | [standalone]

#1523322

FromSekhar Nori <nsekhar@ti.com>
Date2016-11-16 10:20 +0100
Message-ID<sE4xP-We-19@gated-at.bofh.it>
In reply to#1522584
On Tuesday 15 November 2016 04:30 PM, Bartosz Golaszewski wrote:
> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
> controller drivers to da850.dtsi.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Applied to v4.10/dt

Thanks,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1527984

FromDavid Lechner <david@lechnology.com>
Date2016-11-22 23:30 +0100
Message-ID<sGrJD-4Po-17@gated-at.bofh.it>
In reply to#1522584
On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
> controller drivers to da850.dtsi.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> v1 -> v2:
> - moved the priority controller node above the cfgchip node
> - renamed added nodes to better reflect their purpose
>
>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 1bb1f6d..412eec6 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -210,6 +210,10 @@
>  			};
>
>  		};
> +		prictrl: priority-controller@14110 {
> +			compatible = "ti,da850-mstpri";
> +			reg = <0x14110 0x0c>;

I think we should add status = "disabled"; here and let boards opt in.

> +		};
>  		cfgchip: chip-controller@1417c {
>  			compatible = "ti,da830-cfgchip", "syscon", "simple-mfd";
>  			reg = <0x1417c 0x14>;
> @@ -451,4 +455,8 @@
>  			  1 0 0x68000000 0x00008000>;
>  		status = "disabled";
>  	};
> +	memctrl: memory-controller@b0000000 {
> +		compatible = "ti,da850-ddr-controller";
> +		reg = <0xb0000000 0xe8>;

same here. status = "disabled";

> +	};
>  };
>

[toc] | [prev] | [next] | [standalone]

#1528302

FromBartosz Golaszewski <bgolaszewski@baylibre.com>
Date2016-11-23 11:40 +0100
Message-ID<sGD86-3GY-37@gated-at.bofh.it>
In reply to#1527984
2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>
>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>> controller drivers to da850.dtsi.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> v1 -> v2:
>> - moved the priority controller node above the cfgchip node
>> - renamed added nodes to better reflect their purpose
>>
>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index 1bb1f6d..412eec6 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -210,6 +210,10 @@
>>                         };
>>
>>                 };
>> +               prictrl: priority-controller@14110 {
>> +                       compatible = "ti,da850-mstpri";
>> +                       reg = <0x14110 0x0c>;
>
>
> I think we should add status = "disabled"; here and let boards opt in.
>
>> +               };
>>                 cfgchip: chip-controller@1417c {
>>                         compatible = "ti,da830-cfgchip", "syscon",
>> "simple-mfd";
>>                         reg = <0x1417c 0x14>;
>> @@ -451,4 +455,8 @@
>>                           1 0 0x68000000 0x00008000>;
>>                 status = "disabled";
>>         };
>> +       memctrl: memory-controller@b0000000 {
>> +               compatible = "ti,da850-ddr-controller";
>> +               reg = <0xb0000000 0xe8>;
>
>
> same here. status = "disabled";
>
>> +       };
>>  };
>>

Hi David,

I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4].

FYI this patch has already been queued by Sekhar.

Best regards,
Bartosz Golaszewski

[1] https://www.spinics.net/lists/arm-kernel/msg539638.html
[2] http://www.spinics.net/lists/devicetree/msg148575.html
[3] http://www.spinics.net/lists/devicetree/msg148667.html
[4] http://www.spinics.net/lists/devicetree/msg148655.html

[toc] | [prev] | [next] | [standalone]

#1528557

FromDavid Lechner <david@lechnology.com>
Date2016-11-23 17:30 +0100
Message-ID<sGIAN-7bC-19@gated-at.bofh.it>
In reply to#1528302
On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote:
> 2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>>
>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>>> controller drivers to da850.dtsi.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>> v1 -> v2:
>>> - moved the priority controller node above the cfgchip node
>>> - renamed added nodes to better reflect their purpose
>>>
>>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 1bb1f6d..412eec6 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -210,6 +210,10 @@
>>>                         };
>>>
>>>                 };
>>> +               prictrl: priority-controller@14110 {
>>> +                       compatible = "ti,da850-mstpri";
>>> +                       reg = <0x14110 0x0c>;
>>
>>
>> I think we should add status = "disabled"; here and let boards opt in.
>>
>>> +               };
>>>                 cfgchip: chip-controller@1417c {
>>>                         compatible = "ti,da830-cfgchip", "syscon",
>>> "simple-mfd";
>>>                         reg = <0x1417c 0x14>;
>>> @@ -451,4 +455,8 @@
>>>                           1 0 0x68000000 0x00008000>;
>>>                 status = "disabled";
>>>         };
>>> +       memctrl: memory-controller@b0000000 {
>>> +               compatible = "ti,da850-ddr-controller";
>>> +               reg = <0xb0000000 0xe8>;
>>
>>
>> same here. status = "disabled";
>>
>>> +       };
>>>  };
>>>
>
> Hi David,
>
> I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4].
>
> FYI this patch has already been queued by Sekhar.

Thanks. I did not see those threads.

FYI to maintainers, having these enabled by default causes error 
messages in the kernel log for other boards that are not supported by 
the drivers. Since there is only one board that is supported and soon to 
be 2 that are not, I would rather have this disabled by default to avoid 
the error messages.

>
> Best regards,
> Bartosz Golaszewski
>
> [1] https://www.spinics.net/lists/arm-kernel/msg539638.html
> [2] http://www.spinics.net/lists/devicetree/msg148575.html
> [3] http://www.spinics.net/lists/devicetree/msg148667.html
> [4] http://www.spinics.net/lists/devicetree/msg148655.html
>

[toc] | [prev] | [next] | [standalone]

#1528809

FromKevin Hilman <khilman@baylibre.com>
Date2016-11-23 23:40 +0100
Message-ID<sGOmR-2pg-19@gated-at.bofh.it>
In reply to#1528557
David Lechner <david@lechnology.com> writes:

> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote:
>> 2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
>>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>>>
>>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>>>> controller drivers to da850.dtsi.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>> ---
>>>> v1 -> v2:
>>>> - moved the priority controller node above the cfgchip node
>>>> - renamed added nodes to better reflect their purpose
>>>>
>>>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>>>  1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>>> index 1bb1f6d..412eec6 100644
>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>> @@ -210,6 +210,10 @@
>>>>                         };
>>>>
>>>>                 };
>>>> +               prictrl: priority-controller@14110 {
>>>> +                       compatible = "ti,da850-mstpri";
>>>> +                       reg = <0x14110 0x0c>;
>>>
>>>
>>> I think we should add status = "disabled"; here and let boards opt in.
>>>
>>>> +               };
>>>>                 cfgchip: chip-controller@1417c {
>>>>                         compatible = "ti,da830-cfgchip", "syscon",
>>>> "simple-mfd";
>>>>                         reg = <0x1417c 0x14>;
>>>> @@ -451,4 +455,8 @@
>>>>                           1 0 0x68000000 0x00008000>;
>>>>                 status = "disabled";
>>>>         };
>>>> +       memctrl: memory-controller@b0000000 {
>>>> +               compatible = "ti,da850-ddr-controller";
>>>> +               reg = <0xb0000000 0xe8>;
>>>
>>>
>>> same here. status = "disabled";
>>>
>>>> +       };
>>>>  };
>>>>
>>
>> Hi David,
>>
>> I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4].
>>
>> FYI this patch has already been queued by Sekhar.
>
> Thanks. I did not see those threads.
>
> FYI to maintainers, having these enabled by default causes error
> messages in the kernel log for other boards that are not supported by
> the drivers.

Then the driver is too noisy and should be cleaned up.

> Since there is only one board that is supported and soon
> to be 2 that are not, I would rather have this disabled by default to
> avoid the error messages.

IMO, what exactly are the error messages? Sounds like the driver is
being too verbose, and calling things errors that are not really errors.

Kevin

[toc] | [prev] | [next] | [standalone]

#1528820

FromDavid Lechner <david@lechnology.com>
Date2016-11-23 23:50 +0100
Message-ID<sGOwy-2sG-21@gated-at.bofh.it>
In reply to#1528809
On 11/23/2016 04:32 PM, Kevin Hilman wrote:
> David Lechner <david@lechnology.com> writes:
>
>> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote:
>>> 2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
>>>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>>>>
>>>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>>>>> controller drivers to da850.dtsi.
>>>>>
>>>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>>> ---
>>>>> v1 -> v2:
>>>>> - moved the priority controller node above the cfgchip node
>>>>> - renamed added nodes to better reflect their purpose
>>>>>
>>>>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>>>>  1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>>>> index 1bb1f6d..412eec6 100644
>>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>>> @@ -210,6 +210,10 @@
>>>>>                         };
>>>>>
>>>>>                 };
>>>>> +               prictrl: priority-controller@14110 {
>>>>> +                       compatible = "ti,da850-mstpri";
>>>>> +                       reg = <0x14110 0x0c>;
>>>>
>>>>
>>>> I think we should add status = "disabled"; here and let boards opt in.
>>>>
>>>>> +               };
>>>>>                 cfgchip: chip-controller@1417c {
>>>>>                         compatible = "ti,da830-cfgchip", "syscon",
>>>>> "simple-mfd";
>>>>>                         reg = <0x1417c 0x14>;
>>>>> @@ -451,4 +455,8 @@
>>>>>                           1 0 0x68000000 0x00008000>;
>>>>>                 status = "disabled";
>>>>>         };
>>>>> +       memctrl: memory-controller@b0000000 {
>>>>> +               compatible = "ti,da850-ddr-controller";
>>>>> +               reg = <0xb0000000 0xe8>;
>>>>
>>>>
>>>> same here. status = "disabled";
>>>>
>>>>> +       };
>>>>>  };
>>>>>
>>>
>>> Hi David,
>>>
>>> I did that initially[1][2] and it was rejected by Kevin[3] and Laurent[4].
>>>
>>> FYI this patch has already been queued by Sekhar.
>>
>> Thanks. I did not see those threads.
>>
>> FYI to maintainers, having these enabled by default causes error
>> messages in the kernel log for other boards that are not supported by
>> the drivers.
>
> Then the driver is too noisy and should be cleaned up.
>
>> Since there is only one board that is supported and soon
>> to be 2 that are not, I would rather have this disabled by default to
>> avoid the error messages.
>
> IMO, what exactly are the error messages? Sounds like the driver is
> being too verbose, and calling things errors that are not really errors.

It is just one line per driver.

	dev_err(dev, "no master priorities defined for this board\n");

and

	dev_err(dev, "no settings defined for this board\n");


Since "ti,da850-lcdk" is the only board supported in these drivers, all 
other boards will see these error messages.

Also, these modules will be loaded and taking up memory on boards that 
don't use them. This not really a big deal and they can be explicitly 
disabled, so maybe it was not worth mentioning.


>
> Kevin
>

[toc] | [prev] | [next] | [standalone]

#1528981

FromSekhar Nori <nsekhar@ti.com>
Date2016-11-24 06:10 +0100
Message-ID<sGUsh-6pb-17@gated-at.bofh.it>
In reply to#1528820
On Thursday 24 November 2016 04:18 AM, David Lechner wrote:
> On 11/23/2016 04:32 PM, Kevin Hilman wrote:
>> David Lechner <david@lechnology.com> writes:
>>
>>> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote:
>>>> 2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
>>>>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>>>>>
>>>>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>>>>>> controller drivers to da850.dtsi.
>>>>>>
>>>>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>>>> ---
>>>>>> v1 -> v2:
>>>>>> - moved the priority controller node above the cfgchip node
>>>>>> - renamed added nodes to better reflect their purpose
>>>>>>
>>>>>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>>>>>  1 file changed, 8 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/da850.dtsi
>>>>>> b/arch/arm/boot/dts/da850.dtsi
>>>>>> index 1bb1f6d..412eec6 100644
>>>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>>>> @@ -210,6 +210,10 @@
>>>>>>                         };
>>>>>>
>>>>>>                 };
>>>>>> +               prictrl: priority-controller@14110 {
>>>>>> +                       compatible = "ti,da850-mstpri";
>>>>>> +                       reg = <0x14110 0x0c>;
>>>>>
>>>>>
>>>>> I think we should add status = "disabled"; here and let boards opt in.
>>>>>
>>>>>> +               };
>>>>>>                 cfgchip: chip-controller@1417c {
>>>>>>                         compatible = "ti,da830-cfgchip", "syscon",
>>>>>> "simple-mfd";
>>>>>>                         reg = <0x1417c 0x14>;
>>>>>> @@ -451,4 +455,8 @@
>>>>>>                           1 0 0x68000000 0x00008000>;
>>>>>>                 status = "disabled";
>>>>>>         };
>>>>>> +       memctrl: memory-controller@b0000000 {
>>>>>> +               compatible = "ti,da850-ddr-controller";
>>>>>> +               reg = <0xb0000000 0xe8>;
>>>>>
>>>>>
>>>>> same here. status = "disabled";
>>>>>
>>>>>> +       };
>>>>>>  };
>>>>>>
>>>>
>>>> Hi David,
>>>>
>>>> I did that initially[1][2] and it was rejected by Kevin[3] and
>>>> Laurent[4].
>>>>
>>>> FYI this patch has already been queued by Sekhar.
>>>
>>> Thanks. I did not see those threads.
>>>
>>> FYI to maintainers, having these enabled by default causes error
>>> messages in the kernel log for other boards that are not supported by
>>> the drivers.
>>
>> Then the driver is too noisy and should be cleaned up.
>>
>>> Since there is only one board that is supported and soon
>>> to be 2 that are not, I would rather have this disabled by default to
>>> avoid the error messages.
>>
>> IMO, what exactly are the error messages? Sounds like the driver is
>> being too verbose, and calling things errors that are not really errors.
> 
> It is just one line per driver.
> 
>     dev_err(dev, "no master priorities defined for this board\n");
> 
> and
> 
>     dev_err(dev, "no settings defined for this board\n");
> 
> 
> Since "ti,da850-lcdk" is the only board supported in these drivers, all
> other boards will see these error messages.

Thats pretty bad. Sorry about that. The original justification for
keeping them enabled all the time was that they are in-SoC modules with
no external dependencies (like IO lines or voltage rails) so they can be
enabled on all boards that use DA850. While that remains true, the
configuration itself is board specific.

I think the error messages are still useful, so instead of silencing
them, I think we should go back to keeping these nodes disabled by
default and enabling only on boards which have support for it in the driver.

Thanks,
Sekhar

[toc] | [prev] | [next] | [standalone]

#1529068

FromBartosz Golaszewski <bgolaszewski@baylibre.com>
Date2016-11-24 09:50 +0100
Message-ID<sGXTb-iI-11@gated-at.bofh.it>
In reply to#1528981
2016-11-24 6:03 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Thursday 24 November 2016 04:18 AM, David Lechner wrote:
>> On 11/23/2016 04:32 PM, Kevin Hilman wrote:
>>> David Lechner <david@lechnology.com> writes:
>>>
>>>> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote:
>>>>> 2016-11-22 23:23 GMT+01:00 David Lechner <david@lechnology.com>:
>>>>>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:
>>>>>>>
>>>>>>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory
>>>>>>> controller drivers to da850.dtsi.
>>>>>>>
>>>>>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>>>>> ---
>>>>>>> v1 -> v2:
>>>>>>> - moved the priority controller node above the cfgchip node
>>>>>>> - renamed added nodes to better reflect their purpose
>>>>>>>
>>>>>>>  arch/arm/boot/dts/da850.dtsi | 8 ++++++++
>>>>>>>  1 file changed, 8 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/da850.dtsi
>>>>>>> b/arch/arm/boot/dts/da850.dtsi
>>>>>>> index 1bb1f6d..412eec6 100644
>>>>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>>>>> @@ -210,6 +210,10 @@
>>>>>>>                         };
>>>>>>>
>>>>>>>                 };
>>>>>>> +               prictrl: priority-controller@14110 {
>>>>>>> +                       compatible = "ti,da850-mstpri";
>>>>>>> +                       reg = <0x14110 0x0c>;
>>>>>>
>>>>>>
>>>>>> I think we should add status = "disabled"; here and let boards opt in.
>>>>>>
>>>>>>> +               };
>>>>>>>                 cfgchip: chip-controller@1417c {
>>>>>>>                         compatible = "ti,da830-cfgchip", "syscon",
>>>>>>> "simple-mfd";
>>>>>>>                         reg = <0x1417c 0x14>;
>>>>>>> @@ -451,4 +455,8 @@
>>>>>>>                           1 0 0x68000000 0x00008000>;
>>>>>>>                 status = "disabled";
>>>>>>>         };
>>>>>>> +       memctrl: memory-controller@b0000000 {
>>>>>>> +               compatible = "ti,da850-ddr-controller";
>>>>>>> +               reg = <0xb0000000 0xe8>;
>>>>>>
>>>>>>
>>>>>> same here. status = "disabled";
>>>>>>
>>>>>>> +       };
>>>>>>>  };
>>>>>>>
>>>>>
>>>>> Hi David,
>>>>>
>>>>> I did that initially[1][2] and it was rejected by Kevin[3] and
>>>>> Laurent[4].
>>>>>
>>>>> FYI this patch has already been queued by Sekhar.
>>>>
>>>> Thanks. I did not see those threads.
>>>>
>>>> FYI to maintainers, having these enabled by default causes error
>>>> messages in the kernel log for other boards that are not supported by
>>>> the drivers.
>>>
>>> Then the driver is too noisy and should be cleaned up.
>>>
>>>> Since there is only one board that is supported and soon
>>>> to be 2 that are not, I would rather have this disabled by default to
>>>> avoid the error messages.
>>>
>>> IMO, what exactly are the error messages? Sounds like the driver is
>>> being too verbose, and calling things errors that are not really errors.
>>
>> It is just one line per driver.
>>
>>     dev_err(dev, "no master priorities defined for this board\n");
>>
>> and
>>
>>     dev_err(dev, "no settings defined for this board\n");
>>
>>
>> Since "ti,da850-lcdk" is the only board supported in these drivers, all
>> other boards will see these error messages.
>
> Thats pretty bad. Sorry about that. The original justification for
> keeping them enabled all the time was that they are in-SoC modules with
> no external dependencies (like IO lines or voltage rails) so they can be
> enabled on all boards that use DA850. While that remains true, the
> configuration itself is board specific.
>
> I think the error messages are still useful, so instead of silencing
> them, I think we should go back to keeping these nodes disabled by
> default and enabling only on boards which have support for it in the driver.
>
> Thanks,
> Sekhar

I'll send a patch.

Thanks,
Bartosz

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web