Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1526187 > unrolled thread

[PATCH net 16/18] net/ena: fix error handling when probe fails

Started byNetanel Belgazal <netanel@annapurnalabs.com>
First post2016-11-20 09:50 +0100
Last post2016-11-20 09:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH net 16/18] net/ena: fix error handling when probe fails Netanel Belgazal <netanel@annapurnalabs.com> - 2016-11-20 09:50 +0100

#1526187 — [PATCH net 16/18] net/ena: fix error handling when probe fails

FromNetanel Belgazal <netanel@annapurnalabs.com>
Date2016-11-20 09:50 +0100
Subject[PATCH net 16/18] net/ena: fix error handling when probe fails
Message-ID<sFvZ0-dB-11@gated-at.bofh.it>
When driver fails in probe, it will release all resources, including
adapter.
In case of probe failure, ena_remove should not try to free the adapter
resources.

Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index bff082a..ba395aa 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -3179,6 +3179,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_free_region:
 	ena_release_bars(ena_dev, pdev);
 err_free_ena_dev:
+	pci_set_drvdata(pdev, NULL);
 	vfree(ena_dev);
 err_disable_device:
 	pci_disable_device(pdev);
-- 
1.9.1

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web