Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526363 > unrolled thread

[PATCH] ext4: remove unused function ext4_aligned_io()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] ext4: remove unused function ext4_aligned_io() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-11-21 06:10 +0100
    Re: [PATCH] ext4: remove unused function ext4_aligned_io() Theodore Ts'o <tytso@mit.edu> - 2016-11-21 18:00 +0100

#1526363 — [PATCH] ext4: remove unused function ext4_aligned_io()

The last user of ext4_aligned_io() was the DAX path in
ext4_direct_IO_write().  This usage was removed by Jan Kara's patch
entitled "ext4: Rip out DAX handling from direct IO path".

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 fs/ext4/ext4.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 8b76311..8a8a9b2 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -3262,13 +3262,6 @@ static inline void ext4_clear_io_unwritten_flag(ext4_io_end_t *io_end)
 	}
 }
 
-static inline bool ext4_aligned_io(struct inode *inode, loff_t off, loff_t len)
-{
-	int blksize = 1 << inode->i_blkbits;
-
-	return IS_ALIGNED(off, blksize) && IS_ALIGNED(len, blksize);
-}
-
 extern struct iomap_ops ext4_iomap_ops;
 
 #endif	/* __KERNEL__ */
-- 
2.7.4

[toc] | [next] | [standalone]

#1526917

On Sun, Nov 20, 2016 at 10:02:17PM -0700, Ross Zwisler wrote:
> The last user of ext4_aligned_io() was the DAX path in
> ext4_direct_IO_write().  This usage was removed by Jan Kara's patch
> entitled "ext4: Rip out DAX handling from direct IO path".
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Applied, thanks.

						- Ted

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web