Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1523314 > unrolled thread
| Started by | wenpan <wenpan@hisilicon.com> |
|---|---|
| First post | 2016-11-16 10:00 +0100 |
| Last post | 2016-11-18 07:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support wenpan <wenpan@hisilicon.com> - 2016-11-16 10:00 +0100
Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support Wei Xu <xuwei5@hisilicon.com> - 2016-11-16 10:40 +0100
Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-11-17 04:10 +0100
Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-11-18 07:50 +0100
| From | wenpan <wenpan@hisilicon.com> |
|---|---|
| Date | 2016-11-16 10:00 +0100 |
| Subject | Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support |
| Message-ID | <sE4et-Ay-9@gated-at.bofh.it> |
Hi Martyo< Does this confict with your patcho< If noto< I hope this could be merged first. Besides could you tell me the link to your related patch? Thanks, Pan On 2016/10/17 21:48, Arnd Bergmann wrote: > On Monday, October 17, 2016 8:07:03 PM CEST Pan Wen wrote: >> Add support for some HiSilicon SoCs which depend on ARCH_MULTI_V5. >> >> Signed-off-by: Pan Wen <wenpan@hisilicon.com> >> > > Looks ok. I've added Marty Plummer to Cc, he was recently proposing > patches for Hi3520, which I think is closely related to this one. > Please try to work together so the patches don't conflict. It should > be fairly straightforward since you are basically doing the same > change here. > > Arnd > > . >
[toc] | [next] | [standalone]
| From | Wei Xu <xuwei5@hisilicon.com> |
|---|---|
| Date | 2016-11-16 10:40 +0100 |
| Message-ID | <sE4Rb-12s-5@gated-at.bofh.it> |
| In reply to | #1523314 |
Hi Pan, On 2016/11/16 8:56, wenpan wrote: > Hi Marty， > Does this confict with your patch？ If not，I hope this could be merged first. Besides could you tell me the link to your related patch? This is the link: https://patchwork.kernel.org/patch/9334743/ BR, Wei > > Thanks, > Pan > > On 2016/10/17 21:48, Arnd Bergmann wrote: >> On Monday, October 17, 2016 8:07:03 PM CEST Pan Wen wrote: >>> Add support for some HiSilicon SoCs which depend on ARCH_MULTI_V5. >>> >>> Signed-off-by: Pan Wen <wenpan@hisilicon.com> >>> >> >> Looks ok. I've added Marty Plummer to Cc, he was recently proposing >> patches for Hi3520, which I think is closely related to this one. >> Please try to work together so the patches don't conflict. It should >> be fairly straightforward since you are basically doing the same >> change here. >> >> Arnd >> >> . >> > > > . >
[toc] | [prev] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@hisilicon.com> |
|---|---|
| Date | 2016-11-17 04:10 +0100 |
| Message-ID | <sElfj-3lP-5@gated-at.bofh.it> |
| In reply to | #1523334 |
Hi Wei， On 2016/11/16 17:31, Wei Xu wrote: > Hi Pan, > > On 2016/11/16 8:56, wenpan wrote: >> Hi Marty， >> Does this confict with your patch？ If not，I hope this could be merged first. Besides could you tell me the link to your related patch? > > This is the link: https://patchwork.kernel.org/patch/9334743/ > Thank you for offering this.If I want to give some comments on Marty's patch, what should I do? For Marty's patch, I think there's no need to add specific config item ARCH_HIxxxx for every chipset. Some existing chipsets depend on ARCH_HISI directly like Hi3519 and Hi3798CV200. If some options like ARM_GIC is removed from ARCH_HISI, this kind of chipsets will must choose other place to select it. I suggest we should keep selecting ARM_GIC under ARCH_HISI as Pan's patch do. The code may be like this: config ARCH_HISI bool "Hisilicon SoC Support" - depends on ARCH_MULTI_V7 + depends on ARCH_MULTI_V5 || ARCH_MULTI_V6 || ARCH_MULTI_V7 select ARM_AMBA - select ARM_GIC + select ARM_GIC if ARCH_MULTI_V7 + select ARM_VIC if ARCH_MULTI_V5 || depends on ARCH_MULTI_V6 select ARM_TIMER_SP804 select POWER_RESET select POWER_RESET_HISI select POWER_SUPPLY What's your opinion? Best Regards, Jiancheng >> On 2016/10/17 21:48, Arnd Bergmann wrote: >>> On Monday, October 17, 2016 8:07:03 PM CEST Pan Wen wrote: >>>> Add support for some HiSilicon SoCs which depend on ARCH_MULTI_V5. >>>> >>>> Signed-off-by: Pan Wen <wenpan@hisilicon.com> >>>> >>> >>> Looks ok. I've added Marty Plummer to Cc, he was recently proposing >>> patches for Hi3520, which I think is closely related to this one. >>> Please try to work together so the patches don't conflict. It should >>> be fairly straightforward since you are basically doing the same >>> change here. >>>
[toc] | [prev] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@hisilicon.com> |
|---|---|
| Date | 2016-11-18 07:50 +0100 |
| Message-ID | <sEL9L-3yY-5@gated-at.bofh.it> |
| In reply to | #1524052 |
Hi Marty, On 2016/11/17 11:03, Jiancheng Xue wrote: > Hi Wei， > > On 2016/11/16 17:31, Wei Xu wrote: >> Hi Pan, >> >> On 2016/11/16 8:56, wenpan wrote: >>> Hi Marty， >>> Does this confict with your patch？ If not，I hope this could be merged first. Besides could you tell me the link to your related patch? >> >> This is the link: https://patchwork.kernel.org/patch/9334743/ >> Could you give your comments on this patch? If you have any objections to it, please let us know. > > Thank you for offering this.If I want to give some comments on Marty's patch, > what should I do? > > For Marty's patch, I think there's no need to add specific config item ARCH_HIxxxx > for every chipset. Some existing chipsets depend on ARCH_HISI directly like Hi3519 > and Hi3798CV200. If some options like ARM_GIC is removed from ARCH_HISI, this kind > of chipsets will must choose other place to select it. I suggest we should keep selecting > ARM_GIC under ARCH_HISI as Pan's patch do. > > The code may be like this: > > config ARCH_HISI > bool "Hisilicon SoC Support" > - depends on ARCH_MULTI_V7 > + depends on ARCH_MULTI_V5 || ARCH_MULTI_V6 || ARCH_MULTI_V7 > select ARM_AMBA > - select ARM_GIC > + select ARM_GIC if ARCH_MULTI_V7 > + select ARM_VIC if ARCH_MULTI_V5 || depends on ARCH_MULTI_V6 > select ARM_TIMER_SP804 > select POWER_RESET > select POWER_RESET_HISI > select POWER_SUPPLY > What's your opinion about this? Best Regards, Jiancheng >>> On 2016/10/17 21:48, Arnd Bergmann wrote: >>>> On Monday, October 17, 2016 8:07:03 PM CEST Pan Wen wrote: >>>>> Add support for some HiSilicon SoCs which depend on ARCH_MULTI_V5. >>>>> >>>>> Signed-off-by: Pan Wen <wenpan@hisilicon.com> >>>>> >>>> >>>> Looks ok. I've added Marty Plummer to Cc, he was recently proposing >>>> patches for Hi3520, which I think is closely related to this one. >>>> Please try to work together so the patches don't conflict. It should >>>> be fairly straightforward since you are basically doing the same >>>> change here. >>>> > > > > . >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web