Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1520238 > unrolled thread

Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS  support Borislav Petkov <bp@alien8.de> - 2016-11-12 14:00 +0100
    Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS  support He Chen <he.chen@linux.intel.com> - 2016-11-14 02:50 +0100
      Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS  support Borislav Petkov <bp@alien8.de> - 2016-11-14 07:00 +0100
        [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support He Chen <he.chen@linux.intel.com> - 2016-11-14 09:50 +0100
          Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support kbuild test robot <lkp@intel.com> - 2016-11-14 21:30 +0100
            Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support He Chen <he.chen@linux.intel.com> - 2016-11-15 07:10 +0100
              Re: [kbuild-all] [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and  AVX512_4FMAPS support Fengguang Wu <lkp@intel.com> - 2016-11-15 07:50 +0100
              Re: [kbuild-all] [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and  AVX512_4FMAPS support Ye Xiaolong <xiaolong.ye@intel.com> - 2016-11-21 04:20 +0100
          Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support Radim Krčmář <rkrcmar@redhat.com> - 2016-11-16 22:30 +0100
        Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS  support He Chen <he.chen@linux.intel.com> - 2016-11-14 10:00 +0100

#1520238 — Re: [PATCH v6 3/3] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

On Fri, Nov 11, 2016 at 05:25:36PM +0800, He Chen wrote:
> Add two new AVX512 subfeatures support for KVM guest.
> 
> AVX512_4VNNIW:
> Vector instructions for deep learning enhanced word variable precision.
> 
> AVX512_4FMAPS:
> Vector instructions for deep learning floating-point single precision.
> 
> Reviewed-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> Signed-off-by: He Chen <he.chen@linux.intel.com>
> ---

Whoops, I said it looked ok but missed that SOB chain above.

What does it mean? Did Luwei wrote the patch and you're sending it or
...?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [next] | [standalone]

#1520748

On Sat, Nov 12, 2016 at 01:53:29PM +0100, Borislav Petkov wrote:
> On Fri, Nov 11, 2016 at 05:25:36PM +0800, He Chen wrote:
> > Add two new AVX512 subfeatures support for KVM guest.
> > 
> > AVX512_4VNNIW:
> > Vector instructions for deep learning enhanced word variable precision.
> > 
> > AVX512_4FMAPS:
> > Vector instructions for deep learning floating-point single precision.
> > 
> > Reviewed-by: Borislav Petkov <bp@suse.de>
> > Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> > Signed-off-by: He Chen <he.chen@linux.intel.com>
> > ---
> 
> Whoops, I said it looked ok but missed that SOB chain above.
> 
> What does it mean? Did Luwei wrote the patch and you're sending it or
> ...?
> 
Yep, Luwei wrote it and I send it on behalf of him.

Thanks,
-He

[toc] | [prev] | [next] | [standalone]

#1521335

On Mon, Nov 14, 2016 at 09:41:04AM +0800, He Chen wrote:
> Yep, Luwei wrote it and I send it on behalf of him.

Then it needs to have the following format so that tools can pick up the
proper author:

"From: Luwei ...

<commit message text>

Signed-off-by: He Chen...
Signed-off-by: Luwei...
...
"

git format-patch gives that formatting.

If you want to change the ownership, do the following on the local
commit:

$ git commit --amend --author="Luwei Kang <luwei.kang@intel.com>"

in case it lists you locally as author.

HTH.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [next] | [standalone]

#1521427 — [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

From 2daa60b3c6ab5aa6414ebb33119a34403dad2048 Mon Sep 17 00:00:00 2001
From: Luwei Kang <luwei.kang@intel.com>
Date: Mon, 7 Nov 2016 14:03:20 +0800
Subject: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

Add two new AVX512 subfeatures support for KVM guest.

AVX512_4VNNIW:
Vector instructions for deep learning enhanced word variable precision.

AVX512_4FMAPS:
Vector instructions for deep learning floating-point single precision.

Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: He Chen <he.chen@linux.intel.com>
Signed-off-by: Luwei Kang <luwei.kang@intel.com>
---
 arch/x86/kvm/cpuid.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index afa7bbb..ddcdf7c 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -16,6 +16,7 @@
 #include <linux/export.h>
 #include <linux/vmalloc.h>
 #include <linux/uaccess.h>
+#include <asm/processor.h>
 #include <asm/fpu/internal.h> /* For use_eager_fpu.  Ugh! */
 #include <asm/user.h>
 #include <asm/fpu/xstate.h>
@@ -65,6 +66,11 @@ u64 kvm_supported_xcr0(void)
 
 #define F(x) bit(X86_FEATURE_##x)
 
+/* These are scattered features in cpufeatures.h. */
+#define KVM_CPUID_BIT_AVX512_4VNNIW     2
+#define KVM_CPUID_BIT_AVX512_4FMAPS     3
+#define KF(x) bit(KVM_CPUID_BIT_##x)
+
 int kvm_update_cpuid(struct kvm_vcpu *vcpu)
 {
 	struct kvm_cpuid_entry2 *best;
@@ -376,6 +382,10 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
 	/* cpuid 7.0.ecx*/
 	const u32 kvm_cpuid_7_0_ecx_x86_features = F(PKU) | 0 /*OSPKE*/;
 
+	/* cpuid 7.0.edx*/
+	const u32 kvm_cpuid_7_0_edx_x86_features =
+		KF(AVX512_4VNNIW) | KF(AVX512_4FMAPS);
+
 	/* all calls to cpuid_count() should be made on the same cpu */
 	get_cpu();
 
@@ -458,12 +468,14 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
 			/* PKU is not yet implemented for shadow paging. */
 			if (!tdp_enabled)
 				entry->ecx &= ~F(PKU);
+			entry->edx &= kvm_cpuid_7_0_edx_x86_features;
+			entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
 		} else {
 			entry->ebx = 0;
 			entry->ecx = 0;
+			entry->edx = 0;
 		}
 		entry->eax = 0;
-		entry->edx = 0;
 		break;
 	}
 	case 9:
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1522068 — Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

[Multipart message — attachments visible in raw view] — view raw

Hi He,

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v4.9-rc5]
[cannot apply to next-20161114]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/He-Chen/x86-kvm-Add-AVX512_4VNNIW-and-AVX512_4FMAPS-support/20161114-170941
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   arch/x86/kvm/cpuid.c: In function '__do_cpuid_ent':
>> arch/x86/kvm/cpuid.c:472:18: error: implicit declaration of function 'get_scattered_cpuid_leaf' [-Werror=implicit-function-declaration]
       entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
                     ^~~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/kvm/cpuid.c:472:49: error: 'CPUID_EDX' undeclared (first use in this function)
       entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
                                                    ^~~~~~~~~
   arch/x86/kvm/cpuid.c:472:49: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/get_scattered_cpuid_leaf +472 arch/x86/kvm/cpuid.c

   466				entry->ecx &= kvm_cpuid_7_0_ecx_x86_features;
   467				cpuid_mask(&entry->ecx, CPUID_7_ECX);
   468				/* PKU is not yet implemented for shadow paging. */
   469				if (!tdp_enabled)
   470					entry->ecx &= ~F(PKU);
   471				entry->edx &= kvm_cpuid_7_0_edx_x86_features;
 > 472				entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
   473			} else {
   474				entry->ebx = 0;
   475				entry->ecx = 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1522367 — Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

On Tue, Nov 15, 2016 at 04:24:39AM +0800, kbuild test robot wrote:
> Hi He,
> 
> [auto build test ERROR on kvm/linux-next]
> [also build test ERROR on v4.9-rc5]
> [cannot apply to next-20161114]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/He-Chen/x86-kvm-Add-AVX512_4VNNIW-and-AVX512_4FMAPS-support/20161114-170941
> base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
> config: x86_64-kexec (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    arch/x86/kvm/cpuid.c: In function '__do_cpuid_ent':
> >> arch/x86/kvm/cpuid.c:472:18: error: implicit declaration of function 'get_scattered_cpuid_leaf' [-Werror=implicit-function-declaration]
>        entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
>                      ^~~~~~~~~~~~~~~~~~~~~~~~
> >> arch/x86/kvm/cpuid.c:472:49: error: 'CPUID_EDX' undeclared (first use in this function)
>        entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
>                                                     ^~~~~~~~~
>    arch/x86/kvm/cpuid.c:472:49: note: each undeclared identifier is reported only once for each function it appears in
>    cc1: some warnings being treated as errors
>
I have downloaded .config.gz in attachment and use the .config in it
to build kernel in my local branch again, and I don't see any warn or
error message.

I wonder whether the previous 0001 and 0002 patches have applied to run
this test? Or is there something wrong with my compiler or patches?

Thanks,
-He

[toc] | [prev] | [next] | [standalone]

#1522384 — Re: [kbuild-all] [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

Hi He Chen,

On Tue, Nov 15, 2016 at 02:02:23PM +0800, He Chen wrote:
>On Tue, Nov 15, 2016 at 04:24:39AM +0800, kbuild test robot wrote:
>> Hi He,
>>
>> [auto build test ERROR on kvm/linux-next]
>> [also build test ERROR on v4.9-rc5]
>> [cannot apply to next-20161114]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/He-Chen/x86-kvm-Add-AVX512_4VNNIW-and-AVX512_4FMAPS-support/20161114-170941
>> base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next

>I have downloaded .config.gz in attachment and use the .config in it
>to build kernel in my local branch again, and I don't see any warn or
>error message.
>
>I wonder whether the previous 0001 and 0002 patches have applied to run
>this test? Or is there something wrong with my compiler or patches?

Sorry the robot is not smart enough to see the 0001/0002 patches.
As you may see from the above url, only this patch is applied on top
of the KVM linux-next branch.

Thanks,
Fengguang

[toc] | [prev] | [next] | [standalone]

#1526342 — Re: [kbuild-all] [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

On 11/15, He Chen wrote:
>On Tue, Nov 15, 2016 at 04:24:39AM +0800, kbuild test robot wrote:
>> Hi He,
>> 
>> [auto build test ERROR on kvm/linux-next]
>> [also build test ERROR on v4.9-rc5]
>> [cannot apply to next-20161114]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> 
>> url:    https://github.com/0day-ci/linux/commits/He-Chen/x86-kvm-Add-AVX512_4VNNIW-and-AVX512_4FMAPS-support/20161114-170941
>> base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
>> config: x86_64-kexec (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64 
>> 
>> All errors (new ones prefixed by >>):
>> 
>>    arch/x86/kvm/cpuid.c: In function '__do_cpuid_ent':
>> >> arch/x86/kvm/cpuid.c:472:18: error: implicit declaration of function 'get_scattered_cpuid_leaf' [-Werror=implicit-function-declaration]
>>        entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
>>                      ^~~~~~~~~~~~~~~~~~~~~~~~
>> >> arch/x86/kvm/cpuid.c:472:49: error: 'CPUID_EDX' undeclared (first use in this function)
>>        entry->edx &= get_scattered_cpuid_leaf(7, 0, CPUID_EDX);
>>                                                     ^~~~~~~~~
>>    arch/x86/kvm/cpuid.c:472:49: note: each undeclared identifier is reported only once for each function it appears in
>>    cc1: some warnings being treated as errors
>>
>I have downloaded .config.gz in attachment and use the .config in it
>to build kernel in my local branch again, and I don't see any warn or
>error message.
>
>I wonder whether the previous 0001 and 0002 patches have applied to run
>this test? Or is there something wrong with my compiler or patches?

Hi, He

0day robot has't applied previous 0001 and 0002 patches in this case
for it considered this patch as an individual one. Please ignore this
warning. 

Btw: You could try use git(>=2.9.0) format-patch --base=<commit> (or
--base=auto for convenience) to record what (public, well-known) commit
your patch series was built on.

Thanks,
Xiaolong
>
>Thanks,
>-He
>_______________________________________________
>kbuild-all mailing list
>kbuild-all@lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all

[toc] | [prev] | [next] | [standalone]

#1523852 — Re: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support

2016-11-14 16:45+0800, He Chen:
> From 2daa60b3c6ab5aa6414ebb33119a34403dad2048 Mon Sep 17 00:00:00 2001
> From: Luwei Kang <luwei.kang@intel.com>
> Date: Mon, 7 Nov 2016 14:03:20 +0800
> Subject: [Patch v6.1] x86/kvm: Add AVX512_4VNNIW and AVX512_4FMAPS support
> 
> Add two new AVX512 subfeatures support for KVM guest.
> 
> AVX512_4VNNIW:
> Vector instructions for deep learning enhanced word variable precision.
> 
> AVX512_4FMAPS:
> Vector instructions for deep learning floating-point single precision.
> 
> Reviewed-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: He Chen <he.chen@linux.intel.com>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> ---

I changed the subject tags to 'kvm: x86:' and applied to kvm/queue,
thanks.

[toc] | [prev] | [next] | [standalone]

#1521434

On Mon, Nov 14, 2016 at 06:58:22AM +0100, Borislav Petkov wrote:
> On Mon, Nov 14, 2016 at 09:41:04AM +0800, He Chen wrote:
> > Yep, Luwei wrote it and I send it on behalf of him.
> 
> Then it needs to have the following format so that tools can pick up the
> proper author:
> 
> "From: Luwei ...
> 
> <commit message text>
> 
> Signed-off-by: He Chen...
> Signed-off-by: Luwei...
> ...
> "
> 
> git format-patch gives that formatting.
> 
> If you want to change the ownership, do the following on the local
> commit:
> 
> $ git commit --amend --author="Luwei Kang <luwei.kang@intel.com>"
> 
> in case it lists you locally as author.
> 
> HTH.
> 
I am not sure if it is ok to reply this amended patch in this thread.
or should I send another [Patch v6.1] patchset?

Thanks,
-He

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web