Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1521452 > unrolled thread

Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk

Started byMarcos Paulo de Souza <marcos.souza.org@gmail.com>
First post2016-11-14 10:40 +0100
Last post2016-11-15 00:20 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-14 10:40 +0100
    Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-11-14 23:10 +0100
      Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-15 00:20 +0100

#1521452 — Re: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk

FromMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Date2016-11-14 10:40 +0100
SubjectRe: [PATCH v3] platform/x86/asus-nb-wmi.c: Add X45U quirk
Message-ID<sDlU5-58t-1@gated-at.bofh.it>
ping?

On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
> Without this patch, the Asus X45U wireless card can't be turned
> on (hard-blocked), but after a suspend/resume it just starts working.
> 
> Following this bug report[1], there are other cases like this one, but
> this Asus is the only model that I can test.
> 
> [1] https://ubuntuforums.org/showthread.php?t=2181558
> 
> Cc: stable@vger.kernel.org # 4.4.x-
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> 
> ---
> v2 -> v3:
>  Add stable version in the CC line of stable email address
> v1 -> v2:
>  Add stable copy and specify the stable version to apply this patch
> 
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 26e4cbc..6032b70 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X45U",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
> +		},
> +		.driver_data = &quirk_asus_wapf4,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. X456UA",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> -- 
> 2.7.4

[toc] | [next] | [standalone]


#1522124

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-11-14 23:10 +0100
Message-ID<sDxBU-4rC-37@gated-at.bofh.it>
In reply to#1521452
On Mon, Nov 14, 2016 at 11:32 AM, Marcos Paulo de Souza
<marcos.souza.org@gmail.com> wrote:
> ping?

Please, don't do empty pings especially in top posting.
I will look at this as soon as I can.

>
> On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
>> Without this patch, the Asus X45U wireless card can't be turned
>> on (hard-blocked), but after a suspend/resume it just starts working.
>>
>> Following this bug report[1], there are other cases like this one, but
>> this Asus is the only model that I can test.
>>
>> [1] https://ubuntuforums.org/showthread.php?t=2181558
>>
>> Cc: stable@vger.kernel.org # 4.4.x-
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>>
>> ---
>> v2 -> v3:
>>  Add stable version in the CC line of stable email address
>> v1 -> v2:
>>  Add stable copy and specify the stable version to apply this patch
>>
>>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
>> index 26e4cbc..6032b70 100644
>> --- a/drivers/platform/x86/asus-nb-wmi.c
>> +++ b/drivers/platform/x86/asus-nb-wmi.c
>> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
>>       },
>>       {
>>               .callback = dmi_matched,
>> +             .ident = "ASUSTeK COMPUTER INC. X45U",
>> +             .matches = {
>> +                     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
>> +             },
>> +             .driver_data = &quirk_asus_wapf4,
>> +     },
>> +     {
>> +             .callback = dmi_matched,
>>               .ident = "ASUSTeK COMPUTER INC. X456UA",
>>               .matches = {
>>                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> --
>> 2.7.4



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]


#1522171

FromMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Date2016-11-15 00:20 +0100
Message-ID<sDyHE-59b-21@gated-at.bofh.it>
In reply to#1522124
On Tue, Nov 15, 2016 at 12:05:30AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 14, 2016 at 11:32 AM, Marcos Paulo de Souza
> <marcos.souza.org@gmail.com> wrote:
> > ping?
> 
> Please, don't do empty pings especially in top posting.
> I will look at this as soon as I can.

Hi Andy, my apologies. Thanks a lot for checking my patch.

> 
> >
> > On Mon, Nov 07, 2016 at 10:02:32PM -0200, Marcos Paulo de Souza wrote:
> >> Without this patch, the Asus X45U wireless card can't be turned
> >> on (hard-blocked), but after a suspend/resume it just starts working.
> >>
> >> Following this bug report[1], there are other cases like this one, but
> >> this Asus is the only model that I can test.
> >>
> >> [1] https://ubuntuforums.org/showthread.php?t=2181558
> >>
> >> Cc: stable@vger.kernel.org # 4.4.x-
> >> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> >>
> >> ---
> >> v2 -> v3:
> >>  Add stable version in the CC line of stable email address
> >> v1 -> v2:
> >>  Add stable copy and specify the stable version to apply this patch
> >>
> >>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> >> index 26e4cbc..6032b70 100644
> >> --- a/drivers/platform/x86/asus-nb-wmi.c
> >> +++ b/drivers/platform/x86/asus-nb-wmi.c
> >> @@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
> >>       },
> >>       {
> >>               .callback = dmi_matched,
> >> +             .ident = "ASUSTeK COMPUTER INC. X45U",
> >> +             .matches = {
> >> +                     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> +                     DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
> >> +             },
> >> +             .driver_data = &quirk_asus_wapf4,
> >> +     },
> >> +     {
> >> +             .callback = dmi_matched,
> >>               .ident = "ASUSTeK COMPUTER INC. X456UA",
> >>               .matches = {
> >>                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >> --
> >> 2.7.4
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web