Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1521473 > unrolled thread

[PATCH v6 0/9] tpm: cleanup/fixes in existing event log support

Back to article view | Back to linux.kernel

Contents

  [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support  Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
    [PATCH v6 9/9] tpm: cleanup of printk error messages Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
      Re: [PATCH v6 9/9] tpm: cleanup of printk error messages Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-14 23:30 +0100
        Re: [PATCH v6 9/9] tpm: cleanup of printk error messages Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:20 +0100
    [PATCH v6 2/9] tpm: replace symbolic permission with octal for securityfs files Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
      Re: [PATCH v6 2/9] tpm: replace symbolic permission with octal for  securityfs files Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-14 23:20 +0100
      Re: [PATCH v6 2/9] tpm: replace symbolic permission with octal for  securityfs files Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-14 23:30 +0100
        Re: [tpmdd-devel] [PATCH v6 2/9] tpm: replace symbolic permission  with octal for securityfs files Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:20 +0100
    [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
      Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-22 12:30 +0100
        Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-22 17:50 +0100
          Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Nayna <nayna@linux.vnet.ibm.com> - 2016-11-24 04:20 +0100
            Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-24 13:00 +0100
          Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-24 13:00 +0100
    [PATCH v6 5/9] tpm: have event log use the tpm_chip Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
      Re: [PATCH v6 5/9] tpm: have event log use the tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 00:50 +0100
        Re: [PATCH v6 5/9] tpm: have event log use the tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:20 +0100
    [PATCH v6 6/9] tpm: fix the missing .owner in tpm_bios_measurements_ops Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
      Re: [PATCH v6 6/9] tpm: fix the missing .owner in  tpm_bios_measurements_ops Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-14 23:30 +0100
        Re: [PATCH v6 6/9] tpm: fix the missing .owner in  tpm_bios_measurements_ops Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:20 +0100
    [PATCH v6 1/9] tpm: define a generic open() method for ascii & bios measurements Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
    Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-14 23:40 +0100
      Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:30 +0100
        Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 01:40 +0100
        Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 03:20 +0100
          Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Nayna <nayna@linux.vnet.ibm.com> - 2016-11-15 06:40 +0100
            Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 18:50 +0100
              Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-15 19:10 +0100
                Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 20:00 +0100
                  Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-19 19:40 +0100
                    Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-20 11:00 +0100
                      Re: [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-21 19:30 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1521480 — [PATCH v6 1/9] tpm: define a generic open() method for ascii & bios measurements

open() method for event log ascii and binary bios measurements file
operations are very similar. This patch refactors the code into a
single open() call by passing seq_operations as i_node->private data.

Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm_eventlog.c | 63 ++++++++++-------------------------------
 1 file changed, 15 insertions(+), 48 deletions(-)

diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c
index e722886..42b49c4 100644
--- a/drivers/char/tpm/tpm_eventlog.c
+++ b/drivers/char/tpm/tpm_eventlog.c
@@ -7,6 +7,7 @@
  *	Stefan Berger <stefanb@us.ibm.com>
  *	Reiner Sailer <sailer@watson.ibm.com>
  *	Kylene Hall <kjhall@us.ibm.com>
+ *	Nayna Jain <nayna@linux.vnet.ibm.com>
  *
  * Maintained by: <tpmdd-devel@lists.sourceforge.net>
  *
@@ -304,26 +305,28 @@ static int tpm_ascii_bios_measurements_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static const struct seq_operations tpm_ascii_b_measurments_seqops = {
+static const struct seq_operations tpm_ascii_b_measurements_seqops = {
 	.start = tpm_bios_measurements_start,
 	.next = tpm_bios_measurements_next,
 	.stop = tpm_bios_measurements_stop,
 	.show = tpm_ascii_bios_measurements_show,
 };
 
-static const struct seq_operations tpm_binary_b_measurments_seqops = {
+static const struct seq_operations tpm_binary_b_measurements_seqops = {
 	.start = tpm_bios_measurements_start,
 	.next = tpm_bios_measurements_next,
 	.stop = tpm_bios_measurements_stop,
 	.show = tpm_binary_bios_measurements_show,
 };
 
-static int tpm_ascii_bios_measurements_open(struct inode *inode,
+static int tpm_bios_measurements_open(struct inode *inode,
 					    struct file *file)
 {
 	int err;
 	struct tpm_bios_log *log;
 	struct seq_file *seq;
+	const struct seq_operations *seqops =
+		(const struct seq_operations *)inode->i_private;
 
 	log = kzalloc(sizeof(struct tpm_bios_log), GFP_KERNEL);
 	if (!log)
@@ -333,7 +336,7 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode,
 		goto out_free;
 
 	/* now register seq file */
-	err = seq_open(file, &tpm_ascii_b_measurments_seqops);
+	err = seq_open(file, seqops);
 	if (!err) {
 		seq = file->private_data;
 		seq->private = log;
@@ -349,46 +352,8 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode,
 	goto out;
 }
 
-static const struct file_operations tpm_ascii_bios_measurements_ops = {
-	.open = tpm_ascii_bios_measurements_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = tpm_bios_measurements_release,
-};
-
-static int tpm_binary_bios_measurements_open(struct inode *inode,
-					     struct file *file)
-{
-	int err;
-	struct tpm_bios_log *log;
-	struct seq_file *seq;
-
-	log = kzalloc(sizeof(struct tpm_bios_log), GFP_KERNEL);
-	if (!log)
-		return -ENOMEM;
-
-	if ((err = read_log(log)))
-		goto out_free;
-
-	/* now register seq file */
-	err = seq_open(file, &tpm_binary_b_measurments_seqops);
-	if (!err) {
-		seq = file->private_data;
-		seq->private = log;
-	} else {
-		goto out_free;
-	}
-
-out:
-	return err;
-out_free:
-	kfree(log->bios_event_log);
-	kfree(log);
-	goto out;
-}
-
-static const struct file_operations tpm_binary_bios_measurements_ops = {
-	.open = tpm_binary_bios_measurements_open,
+static const struct file_operations tpm_bios_measurements_ops = {
+	.open = tpm_bios_measurements_open,
 	.read = seq_read,
 	.llseek = seq_lseek,
 	.release = tpm_bios_measurements_release,
@@ -413,15 +378,17 @@ struct dentry **tpm_bios_log_setup(const char *name)
 
 	bin_file =
 	    securityfs_create_file("binary_bios_measurements",
-				   S_IRUSR | S_IRGRP, tpm_dir, NULL,
-				   &tpm_binary_bios_measurements_ops);
+				   S_IRUSR | S_IRGRP, tpm_dir,
+				   (void *)&tpm_binary_b_measurements_seqops,
+				   &tpm_bios_measurements_ops);
 	if (is_bad(bin_file))
 		goto out_tpm;
 
 	ascii_file =
 	    securityfs_create_file("ascii_bios_measurements",
-				   S_IRUSR | S_IRGRP, tpm_dir, NULL,
-				   &tpm_ascii_bios_measurements_ops);
+				   S_IRUSR | S_IRGRP, tpm_dir,
+				   (void *)&tpm_ascii_b_measurements_seqops,
+				   &tpm_bios_measurements_ops);
 	if (is_bad(ascii_file))
 		goto out_bin;
 
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1522150

On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
> This patch set includes the cleanup and bug fixes patches, previously
> part of the "tpm: add the securityfs pseudo files support for TPM 2.0
> firmware event log" patch set, in order to upstream them more quickly.

I applied the patches. I'm not yet sure whether these are part of the
4.10 pull request or whether I postpone to 4.11 (my preference would be
4.10 but I do not want to close that right now). I'll do testing next
week before doing pull request.

I hope that the commits gets some reviews and testing now that they are
easily testable in my master branch.

/Jarkko

> 
> Changelog History:
> 
> v6:
> 
> - Patch "tpm: replace symbolic permission with octal for securityfs files"
>   - New Patch.
> - Patch "tpm: have event log use the tpm_chip"
>   - Changed commit description as per Jason's suggestion.
>   - Fixed bug related to kfree() for bios_event_log.
>   - Moved inode_unlock() just after get_device() in open().
>   - Returned -ENODEV for read_log() ENOMEM error and other errors as it is.
>   - Added comment in tpm_bios_log_teardown() to explain inode_lock()/unlock
>     reasoning.
>   - Splitted .owner into different patch.
> - Patch "tpm: fix the missing .owner in tpm_bios_measurements_ops"
>   - New Patch.
> - Patch "tpm: cleanup of printk error messages"
>   - Replaced dev_info() with dev_warn().
>   - Updated commit description subject line.
> 
> v5:
> 
> - Moved cleanup/fixes patches into this patch set.
> - Patch "fix the race condition between event log access and chip
> getting unregistered"
>   - updated subject line and commit description.
>   - modified fops code to use chip kref.
>   - modified fops to lock inode before accessing inode private data.
>   - renamed tpm_securityfs_data to tpm_chip_seqops, as it no more
>   holds bios log, but associates seqops with respective chip. For
>   the same reason, moved it to tpm.h
> - Patch "replace or remove printk error messages"
>   - cleaned up dev_dbg and used dev_info as applicable.
> 
> v4:
> 
> - Includes feedbacks from Jarkko and Jason.
> - Patch "tpm: define a generic open() method for ascii & bios
> measurements".
>   - Fix indentation issue.
> - Patch "tpm: replace the dynamically allocated bios_dir as
>   struct dentry array". 
>   - Continue to use bios_dir_count variable to use is_bad() checks and
>   to maintain correct order for securityfs_remove() during teardown.
>   - Reset chip->bios_dir_count in teardown() function.
> - Patch "tpm: validate the event log access before tpm_bios_log_setup".
>   - Retain TPM2 check which was removed in previous patch.
>   - Add tpm_bios_log_setup failure handling.
>   - Remove use of private data from v3 version of patch. Add a new
>   member to struct tpm_chip to achieve the same purpose.
> - Patch "tpm: redefine the read_log method to check for ACPI/OF 
> properties sequentially".
>   - Move replacement of CONFIG_TCG_IBMVTPM with CONFIG_OF to
>   this patch from patch 3.
>   - Replace -1 error code with -ENODEV.
> - Patch "tpm: replace the of_find_node_by_name() with dev of_node
> property".
>  - Uses chip->dev.parent->of_node.
>  - Created separate patch for cleanup of pr_err messages.
> - Patch "tpm: remove printk error messages".
>  - New Patch.
> - Patch "tpm: add the securityfs file support for TPM 2.0 event log".
>  - Parses event digests using event alg_id rather than event log header
>  alg_id.
>  - Uses of_property_match_string to differentiate tpm/vtpm compatible
>  property.
>  - Adds the comment for difference in tpm/vtpm endianness.
> 
> v3:
> 
> - Includes the review feedbacks as suggested by Jason.
> - Split of patches into one patch per idea.
> - Generic open() method for ascii/bios measurements.
> - Replacement of of **bios_dir with *bios_dir[3].
> - Verifying readlog() is successful before creating securityfs entries.
> - Generic readlog() to check for ACPI/OF in sequence.
> - read_log_of() method now uses of_node propertry rather than
> calling find_device_by_name.
> - read_log differentiates vtpm/tpm using its compatible property.
> - Cleans pr_err with dev_dbg.
> - Commit msgs subject line prefixed with tpm.
> 
> v2:
> 
> - Fixes issues as given in feedback by Jason.
> - Adds documentation for device tree.
> 
> Nayna Jain (9):
>   tpm: define a generic open() method for ascii & bios measurements
>   tpm: replace symbolic permission with octal for securityfs files
>   tpm: replace dynamically allocated bios_dir with a static array
>   tpm: drop tpm1_chip_register(/unregister)
>   tpm: have event log use the tpm_chip
>   tpm: fix the missing .owner in tpm_bios_measurements_ops
>   tpm: redefine read_log() to handle ACPI/OF at runtime
>   tpm: replace of_find_node_by_name() with dev of_node property
>   tpm: cleanup of printk error messages
> 
>  drivers/char/tpm/Makefile       |  14 +--
>  drivers/char/tpm/tpm-chip.c     |  33 ++----
>  drivers/char/tpm/tpm-sysfs.c    |   3 +
>  drivers/char/tpm/tpm.h          |  14 ++-
>  drivers/char/tpm/tpm_acpi.c     |  38 +++----
>  drivers/char/tpm/tpm_eventlog.c | 222 +++++++++++++++++++++-------------------
>  drivers/char/tpm/tpm_eventlog.h |  22 ++--
>  drivers/char/tpm/tpm_of.c       |  45 +++-----
>  8 files changed, 187 insertions(+), 204 deletions(-)
> 
> -- 
> 2.5.0
> 

[toc] | [prev] | [next] | [standalone]

#1522207

On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote:
> On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
> > This patch set includes the cleanup and bug fixes patches, previously
> > part of the "tpm: add the securityfs pseudo files support for TPM 2.0
> > firmware event log" patch set, in order to upstream them more quickly.
> 
> I applied the patches. I'm not yet sure whether these are part of the
> 4.10 pull request or whether I postpone to 4.11 (my preference would be
> 4.10 but I do not want to close that right now). I'll do testing next
> week before doing pull request.
> 
> I hope that the commits gets some reviews and testing now that they are
> easily testable in my master branch.

Event log still works and they do not seem to break TPM 2.0 (tried both
machine with tpm_crb and tpm_tis).

Stefan: would you mind check that these do not break your TPM 1.2
environment? I already tried wih TPM 1.2 machine but probably would
make sense to peer test.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1522210

On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote:
> On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote:
> > On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
> > > This patch set includes the cleanup and bug fixes patches, previously
> > > part of the "tpm: add the securityfs pseudo files support for TPM 2.0
> > > firmware event log" patch set, in order to upstream them more quickly.
> > 
> > I applied the patches. I'm not yet sure whether these are part of the
> > 4.10 pull request or whether I postpone to 4.11 (my preference would be
> > 4.10 but I do not want to close that right now). I'll do testing next
> > week before doing pull request.
> > 
> > I hope that the commits gets some reviews and testing now that they are
> > easily testable in my master branch.
> 
> Event log still works and they do not seem to break TPM 2.0 (tried both
> machine with tpm_crb and tpm_tis).
> 
> Stefan: would you mind check that these do not break your TPM 1.2
> environment? I already tried wih TPM 1.2 machine but probably would
> make sense to peer test.

They are now also in my next branch, which gets pulled to linux-next in
order to get wider exposure.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1522265

On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote:
> On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote:
> > On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
> > > This patch set includes the cleanup and bug fixes patches, previously
> > > part of the "tpm: add the securityfs pseudo files support for TPM 2.0
> > > firmware event log" patch set, in order to upstream them more quickly.
> > 
> > I applied the patches. I'm not yet sure whether these are part of the
> > 4.10 pull request or whether I postpone to 4.11 (my preference would be
> > 4.10 but I do not want to close that right now). I'll do testing next
> > week before doing pull request.
> > 
> > I hope that the commits gets some reviews and testing now that they are
> > easily testable in my master branch.
> 
> Event log still works and they do not seem to break TPM 2.0 (tried both
> machine with tpm_crb and tpm_tis).
> 
> Stefan: would you mind check that these do not break your TPM 1.2
> environment? I already tried wih TPM 1.2 machine but probably would
> make sense to peer test.

I'm dropping commits 8/9 and 9/9 from my tree and *will not* include
them to my 4.10 pull request.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1522353

On 11/15/2016 07:45 AM, Jarkko Sakkinen wrote:
> On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote:
>> On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote:
>>> On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
>>>> This patch set includes the cleanup and bug fixes patches, previously
>>>> part of the "tpm: add the securityfs pseudo files support for TPM 2.0
>>>> firmware event log" patch set, in order to upstream them more quickly.
>>>
>>> I applied the patches. I'm not yet sure whether these are part of the
>>> 4.10 pull request or whether I postpone to 4.11 (my preference would be
>>> 4.10 but I do not want to close that right now). I'll do testing next
>>> week before doing pull request.
>>>
>>> I hope that the commits gets some reviews and testing now that they are
>>> easily testable in my master branch.
>>
>> Event log still works and they do not seem to break TPM 2.0 (tried both
>> machine with tpm_crb and tpm_tis).
>>
>> Stefan: would you mind check that these do not break your TPM 1.2
>> environment? I already tried wih TPM 1.2 machine but probably would
>> make sense to peer test.
>
> I'm dropping commits 8/9 and 9/9 from my tree and *will not* include
> them to my 4.10 pull request.

Will fix this and resend the patch 8/9 and 9/9 again.

Thanks & Regards,
    - Nayna

>
> /Jarkko
>

[toc] | [prev] | [next] | [standalone]

#1522945

On Tue, Nov 15, 2016 at 11:05:42AM +0530, Nayna wrote:
> 
> 
> On 11/15/2016 07:45 AM, Jarkko Sakkinen wrote:
> > On Mon, Nov 14, 2016 at 04:25:14PM -0800, Jarkko Sakkinen wrote:
> > > On Mon, Nov 14, 2016 at 02:33:23PM -0800, Jarkko Sakkinen wrote:
> > > > On Mon, Nov 14, 2016 at 05:00:47AM -0500, Nayna Jain wrote:
> > > > > This patch set includes the cleanup and bug fixes patches, previously
> > > > > part of the "tpm: add the securityfs pseudo files support for TPM 2.0
> > > > > firmware event log" patch set, in order to upstream them more quickly.
> > > > 
> > > > I applied the patches. I'm not yet sure whether these are part of the
> > > > 4.10 pull request or whether I postpone to 4.11 (my preference would be
> > > > 4.10 but I do not want to close that right now). I'll do testing next
> > > > week before doing pull request.
> > > > 
> > > > I hope that the commits gets some reviews and testing now that they are
> > > > easily testable in my master branch.
> > > 
> > > Event log still works and they do not seem to break TPM 2.0 (tried both
> > > machine with tpm_crb and tpm_tis).
> > > 
> > > Stefan: would you mind check that these do not break your TPM 1.2
> > > environment? I already tried wih TPM 1.2 machine but probably would
> > > make sense to peer test.
> > 
> > I'm dropping commits 8/9 and 9/9 from my tree and *will not* include
> > them to my 4.10 pull request.
> 
> Will fix this and resend the patch 8/9 and 9/9 again.

I applied fix from Colin. I for OF specific patches in this patch set
I do not have means to test the code paths that exercise OF specific
functionality. This is what worries me a bit. If I had tested-by from
someone running a system that can exercise those code paths, I would
be less worried.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1522957

On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote:

> I applied fix from Colin. I for OF specific patches in this patch set
> I do not have means to test the code paths that exercise OF specific
> functionality. This is what worries me a bit. If I had tested-by from
> someone running a system that can exercise those code paths, I would
> be less worried.

I can probably check it next week on my OF systems that do not use event log

Jason

[toc] | [prev] | [next] | [standalone]

#1523010

On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote:
> On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote:
> 
> > I applied fix from Colin. I for OF specific patches in this patch set
> > I do not have means to test the code paths that exercise OF specific
> > functionality. This is what worries me a bit. If I had tested-by from
> > someone running a system that can exercise those code paths, I would
> > be less worried.
> 
> I can probably check it next week on my OF systems that do not use event log

Thanks Jason. I'll apppend your Tested-by's to the commits when you're
done. Probably doing pull request in the latter part of next week.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1526113

On Tue, Nov 15, 2016 at 10:54:53AM -0800, Jarkko Sakkinen wrote:
> On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote:
> > On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote:
> > 
> > > I applied fix from Colin. I for OF specific patches in this patch set
> > > I do not have means to test the code paths that exercise OF specific
> > > functionality. This is what worries me a bit. If I had tested-by from
> > > someone running a system that can exercise those code paths, I would
> > > be less worried.
> > 
> > I can probably check it next week on my OF systems that do not use event log
> 
> Thanks Jason. I'll apppend your Tested-by's to the commits when you're
> done. Probably doing pull request in the latter part of next week.

What are we testing? Your master now? It will need the patch I just
sent or it will fail for me.

Jason

[toc] | [prev] | [next] | [standalone]

#1526205

On Sat, Nov 19, 2016 at 11:36:27AM -0700, Jason Gunthorpe wrote:
> On Tue, Nov 15, 2016 at 10:54:53AM -0800, Jarkko Sakkinen wrote:
> > On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote:
> > > On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote:
> > > 
> > > > I applied fix from Colin. I for OF specific patches in this patch set
> > > > I do not have means to test the code paths that exercise OF specific
> > > > functionality. This is what worries me a bit. If I had tested-by from
> > > > someone running a system that can exercise those code paths, I would
> > > > be less worried.
> > > 
> > > I can probably check it next week on my OF systems that do not use event log
> > 
> > Thanks Jason. I'll apppend your Tested-by's to the commits when you're
> > done. Probably doing pull request in the latter part of next week.
> 
> What are we testing? Your master now? It will need the patch I just
> sent or it will fail for me.

$ git am -3 ~/Desktop/foo.txt 
Patch is empty. Was it split wrong?
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

I'm at the Heathrow airport boarding. Look it more properly later on

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1526967

On Sun, Nov 20, 2016 at 09:58:48AM +0000, Jarkko Sakkinen wrote:
> On Sat, Nov 19, 2016 at 11:36:27AM -0700, Jason Gunthorpe wrote:
> > On Tue, Nov 15, 2016 at 10:54:53AM -0800, Jarkko Sakkinen wrote:
> > > On Tue, Nov 15, 2016 at 11:06:10AM -0700, Jason Gunthorpe wrote:
> > > > On Tue, Nov 15, 2016 at 09:40:12AM -0800, Jarkko Sakkinen wrote:
> > > > 
> > > > > I applied fix from Colin. I for OF specific patches in this patch set
> > > > > I do not have means to test the code paths that exercise OF specific
> > > > > functionality. This is what worries me a bit. If I had tested-by from
> > > > > someone running a system that can exercise those code paths, I would
> > > > > be less worried.
> > > > 
> > > > I can probably check it next week on my OF systems that do not use event log
> > > 
> > > Thanks Jason. I'll apppend your Tested-by's to the commits when you're
> > > done. Probably doing pull request in the latter part of next week.
> > 
> > What are we testing? Your master now? It will need the patch I just
> > sent or it will fail for me.

Your TOT works for me (60632de288aac485b328e0863f0c987062ca9b49)

There is one tiny regression, I'll send a patch for it..

Jason

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web