Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522208 > unrolled thread

Re: [PATCH] z3fold: discourage use of pages that weren't compacted

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] z3fold: discourage use of pages that weren't compacted Andrew Morton <akpm@linux-foundation.org> - 2016-11-15 01:40 +0100
    Re: [PATCH] z3fold: discourage use of pages that weren't compacted Vitaly Wool <vitalywool@gmail.com> - 2016-11-15 14:40 +0100

#1522208 — Re: [PATCH] z3fold: discourage use of pages that weren't compacted

On Fri, 11 Nov 2016 14:02:07 +0100 Vitaly Wool <vitalywool@gmail.com> wrote:

> If a z3fold page couldn't be compacted, we don't want it to be
> used for next object allocation in the first place. It makes more
> sense to add it to the end of the relevant unbuddied list. If that
> page gets compacted later, it will be added to the beginning of
> the list then.
> 
> This simple idea gives 5-7% improvement in randrw fio tests and
> about 10% improvement in fio sequential read/write.

This patch appears to require "z3fold: use per-page spinlock", and
"z3fold: use per-page spinlock" doesn't apply properly.

So things are in a bit of a mess.

I presently have

z3fold-limit-first_num-to-the-actual-range-of-possible-buddy-indexes.patch
z3fold-make-pages_nr-atomic.patch
z3fold-extend-compaction-function.patch

Please take a look, figure out what we should do.  Perhaps do it all as
a coherent series rather than an interdependent dribble?

[toc] | [next] | [standalone]

#1522726

On Tue, Nov 15, 2016 at 1:33 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Fri, 11 Nov 2016 14:02:07 +0100 Vitaly Wool <vitalywool@gmail.com> wrote:
>
>> If a z3fold page couldn't be compacted, we don't want it to be
>> used for next object allocation in the first place. It makes more
>> sense to add it to the end of the relevant unbuddied list. If that
>> page gets compacted later, it will be added to the beginning of
>> the list then.
>>
>> This simple idea gives 5-7% improvement in randrw fio tests and
>> about 10% improvement in fio sequential read/write.
>
> This patch appears to require "z3fold: use per-page spinlock", and
> "z3fold: use per-page spinlock" doesn't apply properly.
>
> So things are in a bit of a mess.

Yep, sorry about that.

> I presently have
>
> z3fold-limit-first_num-to-the-actual-range-of-possible-buddy-indexes.patch
> z3fold-make-pages_nr-atomic.patch
> z3fold-extend-compaction-function.patch

These are not interdependent.

> Please take a look, figure out what we should do.  Perhaps do it all as
> a coherent series rather than an interdependent dribble?

I'll come up with a 2-patch update in a short while.

~vitaly

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web