Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522503 > unrolled thread

Re: [PATCH v7 0/3] Add clockevent for timer-nps driver to NPS400 SoC

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v7 0/3] Add clockevent for timer-nps driver to NPS400 SoC Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-11-15 11:00 +0100
    RE: [PATCH v7 0/3] Add clockevent for timer-nps driver to NPS400 SoC Noam Camus <noamca@mellanox.com> - 2016-11-15 11:20 +0100
      Re: [PATCH v7 0/3] Add clockevent for timer-nps driver to NPS400 SoC Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-11-15 11:40 +0100

#1522503 — Re: [PATCH v7 0/3] Add clockevent for timer-nps driver to NPS400 SoC

On Tue, Nov 15, 2016 at 10:50:56AM +0200, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
> 
> Change log
> ---
> V6 --> V7
> Apply several comments made by Daniel Lezcano:
> 1) Remove CLOCK_EVT_FEAT_PERIODIC support. This way it is
>  pure oneshot driver. This simplifies driver so that:
>  nps_clkevent_add_thread()
>  nps_clkevent_rm_thread()
>  are more clearer without any vague logic if to change
>  TSI bit of current HW thread or not.
> 2) tick_resume is also calls nps_clkevent_rm_thread()
> 3) Few (hopefully last) typo fixes. 
> 
> V5 --> V6
> Apply several comments made by Daniel Lezcano:
> 1) nps_get_timer_clk() - use clk_put() on error scenario
> 2) nps_get_timer_clk() - return EINVAL and not plain 1
> 3) Fix typos in log (double checked with spell checker)
> 
> V4 --> V5
> Apply several comments made by Daniel Lezcano:
> 1) Add __init attribute to nps_get_timer_clk()
> 2) Fix return value of nps_get_timer_clk()
>  when failing to get clk rate
> 3) Change clocksource rate from 301 -> 300
> 
> V3 --> V4
> Main changes are [Thanks for the review]:
> Fix many typos at log [Daniel]
> Add handling for bad return values [Daniel and Thomas]
> Replace use of internal irqchip pointers with existing IRQ API [Thomas]
> Provide interrupt handler (percpu) with dev_id equal to evt [Thomas]
> Fix passing *clk by reference to nps_get_timer_clk() [Daniel]
> 
> V2 --> V3
> Apply Rob Herring comment about backword compatibility
> 
> V1 --> V2
> Apply Daniel Lezcano comments:
> 	CLOCKSOURCE_OF_DECLARE return value
> 	update hotplug callbacks usage
> 	squash of 2 first commits.
> In this version I created new commit to serve as preperation for adding clockevents.
> This way the last patch is more readable with clockevent content.
> ---

Do you want me to take the entire series in my tree, or do you want my acked-by
to push them in your tree ?

[toc] | [next] | [standalone]

#1522519

> From: Daniel Lezcano [mailto:daniel.lezcano@linaro.org] 
> Sent: Tuesday, November 15, 2016 11:58 AM

>Do you want me to take the entire series in my tree, or do you want my acked-by to push them in your tree ?
I do not have tree of my own.
Will appreciate if you take entire series.
I believe it is same as you do with Synopsys ARC driver (by Vineet Gupta)

Many Thanks
Noam

[toc] | [prev] | [next] | [standalone]

#1522532

On Tue, Nov 15, 2016 at 10:02:01AM +0000, Noam Camus wrote:
> > From: Daniel Lezcano [mailto:daniel.lezcano@linaro.org] 
> > Sent: Tuesday, November 15, 2016 11:58 AM
> 
> >Do you want me to take the entire series in my tree, or do you want my acked-by to push them in your tree ?
> I do not have tree of my own.
> Will appreciate if you take entire series.
> I believe it is same as you do with Synopsys ARC driver (by Vineet Gupta)
> 
> Many Thanks
> Noam

Ok, I will sort it out with Vineet.

Thanks.

  -- Daniel

-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web