Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522506 > unrolled thread

[patch] ARM: socfpga: checking the wrong variable

Back to article view | Back to linux.kernel

Contents

  [patch] ARM: socfpga: checking the wrong variable Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-15 11:00 +0100
    Re: [patch] ARM: socfpga: checking the wrong variable Moritz Fischer <moritz.fischer@ettus.com> - 2016-11-15 16:40 +0100

#1522506 — [patch] ARM: socfpga: checking the wrong variable

This is a cut and paste bug.  We had intended to check "sysmgr".

Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
 	}
 
 	sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
-	if (IS_ERR(priv->sdrctl)) {
+	if (IS_ERR(sysmgr)) {
 		dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
 		return PTR_ERR(sysmgr);
 	}

[toc] | [next] | [standalone]

#1522842

Hi Dan,
On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This is a cut and paste bug.  We had intended to check "sysmgr".
>
> Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>

>
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 7ab358e..d4eeb74 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>         }
>
>         sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> -       if (IS_ERR(priv->sdrctl)) {
> +       if (IS_ERR(sysmgr)) {
>                 dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
>                 return PTR_ERR(sysmgr);
>         }

Thanks,

Moritz

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web