Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522066 > unrolled thread

Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve_info

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve_info Paul Moore <paul@paul-moore.com> - 2016-11-14 21:30 +0100
    Re: [PATCH] audit: tame initialization warning len_abuf in  audit_log_execve_info Richard Guy Briggs <rgb@redhat.com> - 2016-11-15 10:00 +0100

#1522066 — Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve_info

On Thu, Nov 10, 2016 at 1:39 AM, Richard Guy Briggs <rgb@redhat.com> wrote:
> Tame initialization warning of len_abuf in audit_log_execve_info even
> though there isn't presently a bug introduced by commit 43761473c254
> ("audit: fix a double fetch in audit_log_single_execve_arg()").  Using
> UNINITIALIZED_VAR instead may mask future bugs.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  kernel/auditsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Compiler warnings are annoying, regardless of if they are actually
problems or not so I'm going to merge this ... although I'm pretty
sure in a year or two somebody is going to submit a one-liner removing
this because it's unnecessary :)

> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index e414dfa..d161b17 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1000,7 +1000,7 @@ static void audit_log_execve_info(struct audit_context *context,
>         long len_rem;
>         long len_full;
>         long len_buf;
> -       long len_abuf;
> +       long len_abuf = 0;
>         long len_tmp;
>         bool require_data;
>         bool encode;
> --
> 1.7.1
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit



-- 
paul moore
www.paul-moore.com

[toc] | [next] | [standalone]

#1522457 — Re: [PATCH] audit: tame initialization warning len_abuf in audit_log_execve_info

On 2016-11-14 15:21, Paul Moore wrote:
> On Thu, Nov 10, 2016 at 1:39 AM, Richard Guy Briggs <rgb@redhat.com> wrote:
> > Tame initialization warning of len_abuf in audit_log_execve_info even
> > though there isn't presently a bug introduced by commit 43761473c254
> > ("audit: fix a double fetch in audit_log_single_execve_arg()").  Using
> > UNINITIALIZED_VAR instead may mask future bugs.
> >
> > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > ---
> >  kernel/auditsc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Compiler warnings are annoying, regardless of if they are actually
> problems or not so I'm going to merge this ... although I'm pretty
> sure in a year or two somebody is going to submit a one-liner removing
> this because it's unnecessary :)

Unnecessary on some versions of some compilers...

> > diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> > index e414dfa..d161b17 100644
> > --- a/kernel/auditsc.c
> > +++ b/kernel/auditsc.c
> > @@ -1000,7 +1000,7 @@ static void audit_log_execve_info(struct audit_context *context,
> >         long len_rem;
> >         long len_full;
> >         long len_buf;
> > -       long len_abuf;
> > +       long len_abuf = 0;
> >         long len_tmp;
> >         bool require_data;
> >         bool encode;

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web