Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522217 > unrolled thread

linux-next: build warning after merge of the tpmdd tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build warning after merge of the tpmdd tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-11-15 02:10 +0100
    Re: linux-next: build warning after merge of the tpmdd tree Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-15 03:20 +0100

#1522217 — linux-next: build warning after merge of the tpmdd tree

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_of.c: In function 'read_log_of':
drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
  sizep = of_get_property(np, "linux,sml-size", NULL);
        ^

Introduced by commit

  4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")

This commit is just wrong :-(

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1522264

On Tue, Nov 15, 2016 at 12:01:07PM +1100, Stephen Rothwell wrote:
> Hi Jarkko,
> 
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/char/tpm/tpm_of.c: In function 'read_log_of':
> drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   sizep = of_get_property(np, "linux,sml-size", NULL);
>         ^
> 
> Introduced by commit
> 
>   4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")
> 
> This commit is just wrong :-(

It really is. I'll drop it from my tree.

> -- 
> Cheers,
> Stephen Rothwell

/Jarkko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web