Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1519824 > unrolled thread

[PATCH] sched/cpuacct: avoid %lld seq_printf warning

Started byMartin Schwidefsky <schwidefsky@de.ibm.com>
First post2016-11-11 15:30 +0100
Last post2016-11-16 13:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] sched/cpuacct: avoid %lld seq_printf warning Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-11-11 15:30 +0100
    [tip:sched/core] sched/cpuacct: Avoid %lld seq_printf warning tip-bot for Martin Schwidefsky <tipbot@zytor.com> - 2016-11-16 13:20 +0100

#1519824 — [PATCH] sched/cpuacct: avoid %lld seq_printf warning

FromMartin Schwidefsky <schwidefsky@de.ibm.com>
Date2016-11-11 15:30 +0100
Subject[PATCH] sched/cpuacct: avoid %lld seq_printf warning
Message-ID<sCl05-5tz-7@gated-at.bofh.it>
For s390 kernel builds I keep getting this warning:

kernel/sched/cpuacct.c: In function 'cpuacct_stats_show':
kernel/sched/cpuacct.c:298:25: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'clock_t {aka long int}' [-Wformat=]
   seq_printf(sf, "%s %lld\n",

Silence the warning by adding an explicit cast.

Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
 kernel/sched/cpuacct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c
index bc0b309c..21072bb 100644
--- a/kernel/sched/cpuacct.c
+++ b/kernel/sched/cpuacct.c
@@ -297,7 +297,7 @@ static int cpuacct_stats_show(struct seq_file *sf, void *v)
 	for (stat = 0; stat < CPUACCT_STAT_NSTATS; stat++) {
 		seq_printf(sf, "%s %lld\n",
 			   cpuacct_stat_desc[stat],
-			   cputime64_to_clock_t(val[stat]));
+			   (long long) cputime64_to_clock_t(val[stat]));
 	}
 
 	return 0;
-- 
2.8.4

[toc] | [next] | [standalone]


#1523419 — [tip:sched/core] sched/cpuacct: Avoid %lld seq_printf warning

Fromtip-bot for Martin Schwidefsky <tipbot@zytor.com>
Date2016-11-16 13:20 +0100
Subject[tip:sched/core] sched/cpuacct: Avoid %lld seq_printf warning
Message-ID<sE7m1-2EG-25@gated-at.bofh.it>
In reply to#1519824
Commit-ID:  527b0a76f41d062381adbb55c8eb61e32cb0bfc9
Gitweb:     http://git.kernel.org/tip/527b0a76f41d062381adbb55c8eb61e32cb0bfc9
Author:     Martin Schwidefsky <schwidefsky@de.ibm.com>
AuthorDate: Fri, 11 Nov 2016 15:27:49 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 16 Nov 2016 10:29:03 +0100

sched/cpuacct: Avoid %lld seq_printf warning

For s390 kernel builds I keep getting this warning:

 kernel/sched/cpuacct.c: In function 'cpuacct_stats_show':
 kernel/sched/cpuacct.c:298:25: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'clock_t {aka long int}' [-Wformat=]
   seq_printf(sf, "%s %lld\n",

Silence the warning by adding an explicit cast.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161111142749.6545-1-schwidefsky@de.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/cpuacct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c
index bc0b309c..9add206 100644
--- a/kernel/sched/cpuacct.c
+++ b/kernel/sched/cpuacct.c
@@ -297,7 +297,7 @@ static int cpuacct_stats_show(struct seq_file *sf, void *v)
 	for (stat = 0; stat < CPUACCT_STAT_NSTATS; stat++) {
 		seq_printf(sf, "%s %lld\n",
 			   cpuacct_stat_desc[stat],
-			   cputime64_to_clock_t(val[stat]));
+			   (long long)cputime64_to_clock_t(val[stat]));
 	}
 
 	return 0;

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web