Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519649 > unrolled thread
| Started by | Nadim Almas <nadim.902@gmail.com> |
|---|---|
| First post | 2016-11-11 11:00 +0100 |
| Last post | 2016-11-14 16:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: i4l: act2000: capi: Removing necessary variable Nadim Almas <nadim.902@gmail.com> - 2016-11-11 11:00 +0100
Re: [PATCH] Staging: i4l: act2000: capi: Removing necessary variable Greg KH <gregkh@linuxfoundation.org> - 2016-11-14 16:00 +0100
| From | Nadim Almas <nadim.902@gmail.com> |
|---|---|
| Date | 2016-11-11 11:00 +0100 |
| Subject | [PATCH] Staging: i4l: act2000: capi: Removing necessary variable |
| Message-ID | <sCgMO-2B1-13@gated-at.bofh.it> |
Removing struct sk_buff *skb from capi.c
The Coccinelle semantic patch used to make this change is as follows:
@@
type T;
identifier D;
@@
- T D;
...when != D
Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
drivers/staging/i4l/act2000/capi.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/i4l/act2000/capi.c b/drivers/staging/i4l/act2000/capi.c
index 61386a7..2c2c77e 100644
--- a/drivers/staging/i4l/act2000/capi.c
+++ b/drivers/staging/i4l/act2000/capi.c
@@ -183,7 +183,6 @@ static void
actcapi_connect_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x82, 0x00);
ACTCAPI_CHKSKB;
@@ -304,7 +303,6 @@ void
actcapi_select_b2_protocol_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(10, 0x40, 0x00);
ACTCAPI_CHKSKB;
@@ -339,7 +337,6 @@ static void
actcapi_select_b3_protocol_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x80, 0x00);
ACTCAPI_CHKSKB;
@@ -360,7 +357,6 @@ static void
actcapi_listen_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x81, 0x00);
ACTCAPI_CHKSKB;
@@ -372,7 +368,6 @@ static void
actcapi_disconnect_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(3, 0x04, 0x00);
ACTCAPI_CHKSKB;
@@ -385,7 +380,6 @@ void
actcapi_disconnect_b3_req(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(17, 0x84, 0x00);
ACTCAPI_CHKSKB;
@@ -402,7 +396,6 @@ void
actcapi_connect_resp(act2000_card *card, act2000_chan *chan, __u8 cause)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(3, 0x02, 0x03);
ACTCAPI_CHKSKB;
@@ -420,7 +413,6 @@ static void
actcapi_connect_active_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x03, 0x03);
ACTCAPI_CHKSKB;
@@ -434,7 +426,6 @@ static void
actcapi_connect_b3_resp(act2000_card *card, act2000_chan *chan, __u8 rejectcause)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR((rejectcause ? 3 : 17), 0x82, 0x03);
ACTCAPI_CHKSKB;
@@ -454,7 +445,6 @@ static void
actcapi_connect_b3_active_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x83, 0x03);
ACTCAPI_CHKSKB;
@@ -467,7 +457,6 @@ static void
actcapi_info_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x07, 0x03);
ACTCAPI_CHKSKB;
@@ -479,7 +468,6 @@ static void
actcapi_disconnect_b3_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x84, 0x03);
ACTCAPI_CHKSKB;
@@ -493,7 +481,6 @@ static void
actcapi_disconnect_resp(act2000_card *card, act2000_chan *chan)
{
actcapi_msg *m;
- struct sk_buff *skb;
ACTCAPI_MKHDR(2, 0x04, 0x03);
ACTCAPI_CHKSKB;
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-11-14 16:00 +0100 |
| Message-ID | <sDqTM-8jU-15@gated-at.bofh.it> |
| In reply to | #1519649 |
On Fri, Nov 11, 2016 at 03:28:21PM +0530, Nadim Almas wrote: > Removing struct sk_buff *skb from capi.c > > The Coccinelle semantic patch used to make this change is as follows: > @@ > type T; > identifier D; > @@ > - T D; > ...when != D > > Signed-off-by: Nadim Almas <nadim.902@gmail.com> > --- > drivers/staging/i4l/act2000/capi.c | 13 ------------- > 1 file changed, 13 deletions(-) Why didn't you test build your patch :( Please ALWAYS do so... greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web