Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1520342 > unrolled thread

[PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

Started byBrian Masney <masneyb@onstation.org>
First post2016-11-12 19:30 +0100
Last post2016-11-12 19:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits Brian Masney <masneyb@onstation.org> - 2016-11-12 19:30 +0100

#1520342 — [PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

FromBrian Masney <masneyb@onstation.org>
Date2016-11-12 19:30 +0100
Subject[PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits
Message-ID<sCLdV-5L4-69@gated-at.bofh.it>
in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
Replace this with sizeof(value[1]).

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/tsl2583.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index fe9d777..78967dc 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -582,7 +582,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
 
 	/* Zero out the table */
 	memset(tsl2583_device_lux, 0, sizeof(tsl2583_device_lux));
-	memcpy(tsl2583_device_lux, &value[1], value[0] * 4);
+	memcpy(tsl2583_device_lux, &value[1], value[0] * sizeof(value[1]));
 
 	ret = len;
 
-- 
2.7.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web