Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519100 > unrolled thread

[PATCH] block: cfq_cpd_alloc() should use @gfp

Back to article view | Back to linux.kernel

Contents

  [PATCH] block: cfq_cpd_alloc() should use @gfp Tejun Heo <tj@kernel.org> - 2016-11-10 17:20 +0100
    Re: [PATCH] block: cfq_cpd_alloc() should use @gfp Jens Axboe <axboe@kernel.dk> - 2016-11-10 18:20 +0100

#1519100 — [PATCH] block: cfq_cpd_alloc() should use @gfp

Re: [bug report] blkcg: replace blkcg_policy->cpd_size with
 ->cpd_alloc/free_fn() methods
Reply-To: 
In-Reply-To: <20161110133426.GA30610@mwanda>

cfq_cpd_alloc() which is the cpd_alloc_fn implementation for cfq was
incorrectly hard coding GFP_KERNEL instead of using the mask specified
through the @gfp parameter.  This currently doesn't cause any actual
issues because all current callers specify GFP_KERNEL.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e4a9bde9589f ("blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods")
---
 block/cfq-iosched.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 5e24d88..3ab6807 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -1596,7 +1596,7 @@ static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
 {
 	struct cfq_group_data *cgd;
 
-	cgd = kzalloc(sizeof(*cgd), GFP_KERNEL);
+	cgd = kzalloc(sizeof(*cgd), gfp);
 	if (!cgd)
 		return NULL;
 	return &cgd->cpd;

[toc] | [next] | [standalone]

#1519166

On 11/10/2016 09:16 AM, Tejun Heo wrote:
> Re: [bug report] blkcg: replace blkcg_policy->cpd_size with
>  ->cpd_alloc/free_fn() methods
> Reply-To:
> In-Reply-To: <20161110133426.GA30610@mwanda>
>
> cfq_cpd_alloc() which is the cpd_alloc_fn implementation for cfq was
> incorrectly hard coding GFP_KERNEL instead of using the mask specified
> through the @gfp parameter.  This currently doesn't cause any actual
> issues because all current callers specify GFP_KERNEL.  Fix it.

Thanks Tejun, applied for 4.10.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web