Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517605 > unrolled thread

Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] checkpatch: Fix warnings when --no-tree is used Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-11-08 22:50 +0100
    Re: [PATCH] checkpatch: Fix warnings when --no-tree is used Joe Perches <joe@perches.com> - 2016-11-09 02:10 +0100

#1517605 — Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

[Multipart message — attachments visible in raw view] — view raw

On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote:
> When users run checkpatch.pl with --no-tree option, $root is not
> defined, which causes an ugly warning that it is not initialized at
> line 764.  The test for whether or not a file is maintained should
> only be run when a kernel tree is defined (i.e. not when --no-tree
> option is being used)
> 
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping? Joe? Andy?  Where are we at with this patch?

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..7a54978 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2352,7 +2352,7 @@ sub process {
>  			}
>  		}
>  
> -		if ($found_file) {
> +		if ($found_file && $tree) {
>  			if (is_maintained_obsolete($realfile)) {
>  				WARN("OBSOLETE",
>  				     "$realfile is marked as 'obsolete'
> in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");

[toc] | [next] | [standalone]

#1517699

On Tue, 2016-11-08 at 13:40 -0800, Jeff Kirsher wrote:
> Ping? Joe? Andy?  Where are we at with this patch?

I think there's a patch in Andrew Morton's queue for this.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web