Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517224 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-11-08 15:10 +0100 |
| Last post | 2016-11-08 21:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] iio: gyro: mpu3050: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2016-11-08 15:10 +0100
Re: [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 16:50 +0100
Re: [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency Jonathan Cameron <jic23@kernel.org> - 2016-11-08 21:40 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-11-08 15:10 +0100 |
| Subject | [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency |
| Message-ID | <sBfg5-1XK-11@gated-at.bofh.it> |
The new mpu3050 driver fails to build if I2C is disabled:
drivers/iio/built-in.o: In function `mpu3050_i2c_driver_exit':
mpu3050-i2c.c:(.exit.text+0x17f): undefined reference to `i2c_del_driver'
drivers/iio/built-in.o: In function `mpu3050_i2c_driver_init':
mpu3050-i2c.c:(.init.text+0x215): undefined reference to `i2c_register_driver'
This adds a Kconfig dependency to ensure we only build it when I2C
is available.
Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/gyro/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
index 107b5efd4178..3126cf05e6b9 100644
--- a/drivers/iio/gyro/Kconfig
+++ b/drivers/iio/gyro/Kconfig
@@ -93,6 +93,7 @@ config MPU3050
config MPU3050_I2C
tristate "Invensense MPU3050 devices on I2C"
depends on !(INPUT_MPU3050=y || INPUT_MPU3050=m)
+ depends on I2C
select MPU3050
select REGMAP_I2C
select I2C_MUX
--
2.9.0
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-11-08 16:50 +0100 |
| Message-ID | <sBgOR-2Jy-7@gated-at.bofh.it> |
| In reply to | #1517224 |
On Tue, Nov 8, 2016 at 2:59 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new mpu3050 driver fails to build if I2C is disabled:
>
> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_exit':
> mpu3050-i2c.c:(.exit.text+0x17f): undefined reference to `i2c_del_driver'
> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_init':
> mpu3050-i2c.c:(.init.text+0x215): undefined reference to `i2c_register_driver'
>
> This adds a Kconfig dependency to ensure we only build it when I2C
> is available.
>
> Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-11-08 21:40 +0100 |
| Message-ID | <sBllw-5TP-5@gated-at.bofh.it> |
| In reply to | #1517303 |
On 08/11/16 15:40, Linus Walleij wrote:
> On Tue, Nov 8, 2016 at 2:59 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> The new mpu3050 driver fails to build if I2C is disabled:
>>
>> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_exit':
>> mpu3050-i2c.c:(.exit.text+0x17f): undefined reference to `i2c_del_driver'
>> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_init':
>> mpu3050-i2c.c:(.init.text+0x215): undefined reference to `i2c_register_driver'
>>
>> This adds a Kconfig dependency to ensure we only build it when I2C
>> is available.
>>
>> Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied. Thanks.
Jonathan
>
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web