Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517522 > unrolled thread

[PATCH v2] irqchip/renesas-irqc: Postpone driver initialization

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Geert Uytterhoeven <geert+renesas@glider.be> - 2016-11-08 20:40 +0100
    Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Florian Fainelli <f.fainelli@gmail.com> - 2016-11-08 20:50 +0100
      Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Geert Uytterhoeven <geert@linux-m68k.org> - 2016-11-08 21:00 +0100
        Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Florian Fainelli <f.fainelli@gmail.com> - 2016-11-09 20:20 +0100
          Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Geert Uytterhoeven <geert@linux-m68k.org> - 2016-11-09 20:50 +0100
    Re: [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization Marc Zyngier <marc.zyngier@arm.com> - 2016-11-09 10:10 +0100

#1517522 — [PATCH v2] irqchip/renesas-irqc: Postpone driver initialization

Currently the renesas-irqc driver uses postcore_initcall().

However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
does not support deferred probe yet.

Replace postcore_initcall() by device_initcall() to work around this.

Note that on R-Mobile APE6, where the PFC/GPIO combo uses the IRQC as
its parent interrupt controller, this does cause a few additional probe
deferrals (for SCIFA0, SD0, SD1, and MMC). But the affected drivers
handle that fine.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
v2:
  - Drop RFC state,
  - Add Tested-by,
  - Improved description.
---
 drivers/irqchip/irq-renesas-irqc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
index 52304b139aa46a60..992849e54d00ea77 100644
--- a/drivers/irqchip/irq-renesas-irqc.c
+++ b/drivers/irqchip/irq-renesas-irqc.c
@@ -295,7 +295,7 @@ static int __init irqc_init(void)
 {
 	return platform_driver_register(&irqc_device_driver);
 }
-postcore_initcall(irqc_init);
+device_initcall(irqc_init);
 
 static void __exit irqc_exit(void)
 {
-- 
1.9.1

[toc] | [next] | [standalone]

#1517525

On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote:
> Currently the renesas-irqc driver uses postcore_initcall().
> 
> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
> IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
> not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
> does not support deferred probe yet.

Is not that the more correct fix to implement though?
-- 
Florian

[toc] | [prev] | [next] | [standalone]

#1517532

Hi Florian,

On Tue, Nov 8, 2016 at 8:42 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote:
>> Currently the renesas-irqc driver uses postcore_initcall().
>>
>> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
>> IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
>> not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
>> does not support deferred probe yet.
>
> Is not that the more correct fix to implement though?

Sure it is. But nothing has happened since this was reported ca. 1 year ago.
Cfr. "of_mdiobus_register_phy() and deferred probe"
https://lkml.org/lkml/2015/10/22/377

My MDIO foo is not that strong...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1518427

On 11/08/2016 11:50 AM, Geert Uytterhoeven wrote:
> Hi Florian,
> 
> On Tue, Nov 8, 2016 at 8:42 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote:
>>> Currently the renesas-irqc driver uses postcore_initcall().
>>>
>>> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
>>> IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
>>> not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
>>> does not support deferred probe yet.
>>
>> Is not that the more correct fix to implement though?
> 
> Sure it is. But nothing has happened since this was reported ca. 1 year ago.
> Cfr. "of_mdiobus_register_phy() and deferred probe"
> https://lkml.org/lkml/2015/10/22/377
> 
> My MDIO foo is not that strong...

Let me try to cook something here which may require
of_mdiobus_register_phy(), are you okay testing patches?
-- 
Florian

[toc] | [prev] | [next] | [standalone]

#1518435

Hi Florian,

On Wed, Nov 9, 2016 at 8:17 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 11/08/2016 11:50 AM, Geert Uytterhoeven wrote:
>> On Tue, Nov 8, 2016 at 8:42 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>>> On 11/08/2016 11:35 AM, Geert Uytterhoeven wrote:
>>>> Currently the renesas-irqc driver uses postcore_initcall().
>>>>
>>>> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
>>>> IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
>>>> not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
>>>> does not support deferred probe yet.
>>>
>>> Is not that the more correct fix to implement though?
>>
>> Sure it is. But nothing has happened since this was reported ca. 1 year ago.
>> Cfr. "of_mdiobus_register_phy() and deferred probe"
>> https://lkml.org/lkml/2015/10/22/377
>>
>> My MDIO foo is not that strong...
>
> Let me try to cook something here which may require
> of_mdiobus_register_phy(), are you okay testing patches?

Of course I am. Thanks a lot!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1517838

Hi Geert,

On 08/11/16 19:35, Geert Uytterhoeven wrote:
> Currently the renesas-irqc driver uses postcore_initcall().
> 
> However, the new CPG/MSSR driver uses subsys_initcall(). Hence the
> IRQC's probe will be deferred, which causes the Micrel Ethernet PHY to
> not find its interrupt on R-Car Gen2 and RZ/G, as the of_mdio subsystem
> does not support deferred probe yet.
> 
> Replace postcore_initcall() by device_initcall() to work around this.
> 
> Note that on R-Mobile APE6, where the PFC/GPIO combo uses the IRQC as
> its parent interrupt controller, this does cause a few additional probe
> deferrals (for SCIFA0, SD0, SD1, and MMC). But the affected drivers
> handle that fine.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> v2:
>   - Drop RFC state,
>   - Add Tested-by,
>   - Improved description.
> ---
>  drivers/irqchip/irq-renesas-irqc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> index 52304b139aa46a60..992849e54d00ea77 100644
> --- a/drivers/irqchip/irq-renesas-irqc.c
> +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -295,7 +295,7 @@ static int __init irqc_init(void)
>  {
>  	return platform_driver_register(&irqc_device_driver);
>  }
> -postcore_initcall(irqc_init);
> +device_initcall(irqc_init);

Overall, I'm not keen on these hacks (by moving from one initcall to
another, you're as likely to fix something than to break something else).

What should really be done is to either teach the various drivers to
handle deferred probing, or to teach the kernel to handle proper
dependencies (vastly more ambitious).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web