Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517213 > unrolled thread

[PATCH] bus: tegra-gmi: fix build error

Back to article view | Back to linux.kernel

Contents

  [PATCH] bus: tegra-gmi: fix build error Arnd Bergmann <arnd@arndb.de> - 2016-11-08 15:00 +0100
    Re: [PATCH] bus: tegra-gmi: fix build error Thierry Reding <thierry.reding@gmail.com> - 2016-11-08 16:50 +0100

#1517213 — [PATCH] bus: tegra-gmi: fix build error

The newly added driver fails to build right away:

drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt':
drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function)

I guess a last-minute change removed a local variable, this
adds the obvious definiton.

Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/bus/tegra-gmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c
index 44ee73186c5e..8b6ab0dd2f4c 100644
--- a/drivers/bus/tegra-gmi.c
+++ b/drivers/bus/tegra-gmi.c
@@ -90,9 +90,10 @@ static int tegra_gmi_parse_dt(struct tegra_gmi *gmi)
 {
 	struct device_node *child;
 	u32 property, ranges[4];
+	struct device *dev = gmi->dev;
 	int err;
 
-	child = of_get_next_available_child(gmi->dev->of_node, NULL);
+	child = of_get_next_available_child(dev->of_node, NULL);
 	if (!child) {
 		dev_err(dev, "no child nodes found\n");
 		return -ENODEV;
-- 
2.9.0

[toc] | [next] | [standalone]

#1517311

[Multipart message — attachments visible in raw view] — view raw

On Tue, Nov 08, 2016 at 02:50:29PM +0100, Arnd Bergmann wrote:
> The newly added driver fails to build right away:
> 
> drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt':
> drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function)
> 
> I guess a last-minute change removed a local variable, this
> adds the obvious definiton.
> 
> Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/bus/tegra-gmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This got reported by the 0-day builder earlier. Turns out this slipped
through because my build setup failed to pick up the new configuration
option. I pushed a fix for this to the Tegra tree, so it should all be
good by tomorrow.

Thanks,
Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web