Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515559 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2016-11-05 15:30 +0100 |
| Last post | 2016-11-08 11:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-11-05 15:30 +0100
Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Patrice Chotard <patrice.chotard@st.com> - 2016-11-07 10:10 +0100
Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Linus Walleij <linus.walleij@linaro.org> - 2016-11-08 11:30 +0100
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-11-05 15:30 +0100 |
| Subject | [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string |
| Message-ID | <sAa8O-zo-9@gated-at.bofh.it> |
function is defined as unsigned int. So we need %u to print it. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index b7bb371..8308f15 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, function = st_pctl_get_pin_function(pc, offset); if (function) - snprintf(f, 10, "Alt Fn %d", function); + snprintf(f, 10, "Alt Fn %u", function); else snprintf(f, 5, "GPIO"); -- 2.10.1
[toc] | [next] | [standalone]
| From | Patrice Chotard <patrice.chotard@st.com> |
|---|---|
| Date | 2016-11-07 10:10 +0100 |
| Message-ID | <sAO6d-UV-11@gated-at.bofh.it> |
| In reply to | #1515559 |
On 11/05/2016 03:25 PM, Heinrich Schuchardt wrote: > function is defined as unsigned int. > So we need %u to print it. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/pinctrl/pinctrl-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index b7bb371..8308f15 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, > > function = st_pctl_get_pin_function(pc, offset); > if (function) > - snprintf(f, 10, "Alt Fn %d", function); > + snprintf(f, 10, "Alt Fn %u", function); > else > snprintf(f, 5, "GPIO"); > > Hi Heinrich Acked-by: Patrice Chotard <patrice.chotard@st.com> Thanks
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-11-08 11:30 +0100 |
| Message-ID | <sBbPc-88c-37@gated-at.bofh.it> |
| In reply to | #1515559 |
On Sat, Nov 5, 2016 at 3:25 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > function is defined as unsigned int. > So we need %u to print it. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Patch applied with Patrice's ACK. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web