Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1516983 > unrolled thread
| Started by | Zhi Zhang <zhang.david2011@gmail.com> |
|---|---|
| First post | 2016-11-08 10:20 +0100 |
| Last post | 2016-11-08 15:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() Zhi Zhang <zhang.david2011@gmail.com> - 2016-11-08 10:20 +0100
Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() Ilya Dryomov <idryomov@gmail.com> - 2016-11-08 14:50 +0100
Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() "Yan, Zheng" <zyan@redhat.com> - 2016-11-08 15:30 +0100
| From | Zhi Zhang <zhang.david2011@gmail.com> |
|---|---|
| Date | 2016-11-08 10:20 +0100 |
| Subject | [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() |
| Message-ID | <sBaJs-7rN-17@gated-at.bofh.it> |
Fix printing wrong return variable for invalidate_inode_pages2_range
in ceph_direct_read_write().
Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
---
fs/ceph/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 18630e8..0136195 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
pos >> PAGE_SHIFT,
(pos + count) >> PAGE_SHIFT);
if (ret2 < 0)
- dout("invalidate_inode_pages2_range returned
%d\n", ret);
+ dout("invalidate_inode_pages2_range returned
%d\n", ret2);
flags = CEPH_OSD_FLAG_ORDERSNAP |
CEPH_OSD_FLAG_ONDISK |
Regards,
Zhi Zhang (David)
Contact: zhang.david2011@gmail.com
zhangz.david@outlook.com
[toc] | [next] | [standalone]
| From | Ilya Dryomov <idryomov@gmail.com> |
|---|---|
| Date | 2016-11-08 14:50 +0100 |
| Message-ID | <sBeWK-1y1-27@gated-at.bofh.it> |
| In reply to | #1516983 |
On Tue, Nov 8, 2016 at 10:16 AM, Zhi Zhang <zhang.david2011@gmail.com> wrote:
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>
Applied.
(This is mangled, and had to be applied manually. Check out
Documentation/email-clients.txt in the kernel tree.)
Thanks,
Ilya
[toc] | [prev] | [next] | [standalone]
| From | "Yan, Zheng" <zyan@redhat.com> |
|---|---|
| Date | 2016-11-08 15:30 +0100 |
| Subject | Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write() |
| Message-ID | <sBfzs-24a-9@gated-at.bofh.it> |
| In reply to | #1516983 |
> On 8 Nov 2016, at 17:16, Zhi Zhang <zhang.david2011@gmail.com> wrote:
>
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <zhang.david2011@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>
>
Applied, Thanks
Yan, Zheng
> Regards,
> Zhi Zhang (David)
> Contact: zhang.david2011@gmail.com
> zhangz.david@outlook.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web